error: no matching function for call to 'upnpDiscover'

[mohamedfawzy96]

net.cpp:1066:15: error: no matching function for call to 'upnpDiscover'
devlist = upnpDiscover(2000, multicastif, minissdpdpath, 0, 0, &error);
^~~~~~~~~~~~
/usr/local/include/miniupnpc/miniupnpc.h:62:1: note: candidate function not
viable: requires 7 arguments, but 6 were provided
upnpDiscover(int delay, const char * multicastif,

This error appears when i try to compile the source code

[maflcko]

Please provide exact steps to reproduce. Including the software you are running on.

[paveljanik]

... especially the version of miniupnpc...

[laanwj]

Yes, looks like an UPNP version conflict.
They like to just slap on arguments sometimes.
If you don't feel like debugging this I'd suggest configuring with --without-miniupnpc.

[mohamedfawzy96]

@paveljanik @MarcoFalke
I'm using mac OS X and I'm trying to compile the source code and every time I "make"... this error pops up.I don't really know which version i'm using.

[mohamedfawzy96]

@laanwj would this effect any of my work flow in the future ?

[mohamedfawzy96]

Version 2.0

[laanwj]

Version 2.0 is the same one as used in gitian, so that should work. Strange. This is the code in question:

#ifndef UPNPDISCOVER_SUCCESS
    /* miniupnpc 1.5 */
    devlist = upnpDiscover(2000, multicastif, minissdpdpath, 0);
#elif MINIUPNPC_API_VERSION < 14
    /* miniupnpc 1.6 */
    int error = 0;
    devlist = upnpDiscover(2000, multicastif, minissdpdpath, 0, 0, &error);
#else
    /* miniupnpc 1.9.20150730 */
    int error = 0;
    devlist = upnpDiscover(2000, multicastif, minissdpdpath, 0, 0, 2, &error);
#endif

It should only be trying to pass 6 arguments if MINIUPNPC_API_VERSION, which is a long time ago.

What version of bitcoin core are you trying to compile?

[mohamedfawzy96]

@laanwj I'm using version 0.9.5 of bitcoin core.

should i try another version of bitcoin core ?

[laanwj]

0.9.5 is old. You should use 0.13.0.

[laanwj]

Closing, build issues with old versions are not supported...

[mohamedfawzy96]

Thank you so much @laanwj

[maflcko]

@mohamedfawzy96 I am interested in your rationale in choosing 0.9.5. Did someone recommend it to you?