Infinite recursion when using -debug and DEBUG_LOCKORDER

[TheBlueMatt]

push_lock -> printf -> OutputDebugStringF -> GetDataDir -> LOCK -> push_lock

[gavinandresen]

LOCK inside OutputDebugStringF or any of the routines it calls is a big no-no...

[sipa]

GetDataDir should not lock, except the first time it is called

[TheBlueMatt]

You could reasonably just remove the lock, GetDataDir is called a few times before any other threads are started, so its pretty safe, but I probably missed an edge case or two.

[sipa]

Or make sure it's called once beforehand?

[TheBlueMatt]

Simple enough either way.

[laanwj]

Is this still the case?

[sipa]

I believe this code was significantly changed since.