Make user actions more straightforward in address book#1215
Make user actions more straightforward in address book#1215laanwj merged 1 commit intobitcoin:masterfrom
Conversation
laanwj
commented
May 7, 2012
laanwj
commented
- Add all actions that can be triggered with buttons to the context menu
- Hide delete action from context menu for receiving tab
- "Copy Address" instead of the vague, longwinded "Copy to Clipboard"
|
Could you add a Sign message button to the address book tab after the QR Code button to be in line with send coins and because you added it to the context menu? I'm asking myself if it is allowed to use a non owned address to sign a message in general? |
|
Yeah I noticed that inconsistency too, however it is not a good idea any more buttons. We'll add future actions only to the context menu. See it like this: The context menu has the authoritative list of actions, the buttons are just there to shortcut a few common ones. There are already various issues about the button row being to wide especially in verbose languages (#1062 is one of them). It would be possible to show only icons for the buttons, but that needs a new pull request. No more cosmetic changes in this one :) And right, you cannot use a non-owned address to sign a message. That'd be kind of contrary to the idea of signing. |
src/qt/addressbookpage.cpp
Outdated
There was a problem hiding this comment.
But you allow signing of non receiving addresses here, no?
There was a problem hiding this comment.
Right, thanks for noticing
- Add all actions that can be triggered with buttons to the context menu - Hide delete action from context menu for receiving tab
|
Fixed |
Make user actions more straightforward in address book
Make user actions more straightforward in address book
…xthins. (bitcoin#1215) Previously we always had set this to 72 hours because on the Legacy chain the memory pools are periodically overfull and it can take several days after startup for the memory pools to get in sync. With Bitcoin Cash the memory pool is cleared almost every block that is mined, so reducing the 72 hour ramp in false positive rates, to 12 seems like good idea while sill leaving room in the event that we have a sudden and likely temporary backup in the mempool.
Pull request description: This pull request adds release notes for the new release. Incomplete.
2 participants
