fix an incorrect if-clause in net.cpp#1225
Merged
jgarzik merged 1 commit intobitcoin:masterfrom May 9, 2012
Diapolo:net_cpp_if_clause
Merged
fix an incorrect if-clause in net.cpp#1225jgarzik merged 1 commit intobitcoin:masterfrom Diapolo:net_cpp_if_clause
jgarzik merged 1 commit intobitcoin:masterfrom
Diapolo:net_cpp_if_clause
Conversation
Member
|
sub-optimal? just call it incorrect :) |
Contributor
|
It still needs the (SOCKET) cast to be portable to all platforms without warnings, I think |
Member
|
Yes, it still needs the (SOCKET) cast, otherwise you'll be comparing a signed against an unsigned value. |
Author
|
:-P² All good ends well? |
Member
|
If you don't like the magic value make it compare against INVALID_SOCKET. After all, it is a socket number. SOCKET_ERROR is a signed error value and is meant for comparing against wsaGetError() output. You wanted to compare against both INVALID_SOCKET and SOCKET_ERROR which is the part I disagreed with. |
Author
|
Updated and rebased! |
Member
|
ACK |
jgarzik
pushed a commit
that referenced
this pull request
May 9, 2012
fix an incorrect if-clause in net.cpp
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
fix an incorrect if-clause in net.cpp
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
* Store time we saw mnb last time, bump sync timeout if we received seen mnb but we are too close to MASTERNODE_NEW_START_REQUIRED_SECONDS * Reset blockchain sync status if new blocks were accepted during sync * Add some debug log output * wait for at least one new block to be accepted * bump CGovernanceManager-Version
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
Use define, rather than hard-coded string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/bitcoin/bitcoin/pull/1180/files#L2R624 for the discussion about this!