Skip to content

guiutil.cpp/.h: fix a -Wreorder compiler warning...#1257

Merged
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:fix_guiutil_warn
May 11, 2012
Merged

guiutil.cpp/.h: fix a -Wreorder compiler warning...#1257
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:fix_guiutil_warn

Conversation

@Diapolo
Copy link
Copy Markdown

@Diapolo Diapolo commented May 11, 2012

  • fix for:
    guiutil.h: In constructor 'GUIUtil::ToolTipToRichTextFilter::ToolTipToRichTextFilter(int, QObject*)':
    guiutil.h:90: warning: 'GUIUtil::ToolTipToRichTextFilter::size_threshold' will be initialized after [-Wreorder]
    guiutil.cpp:252: warning: base 'QObject' [-Wreorder]
    guiutil.cpp:251: warning: when initialized here [-Wreorder]
  • make constructor for ToolTipToRichTextFilter explicit

@sipa
Copy link
Copy Markdown
Member

sipa commented May 11, 2012

Looks safe, and I like squishing warnings (though I don't get this one).

laanwj added a commit that referenced this pull request May 11, 2012
guiutil.cpp/.h: fix a -Wreorder compiler warning...
@laanwj laanwj merged commit 5e7c4f3 into bitcoin:master May 11, 2012
coblee pushed a commit to litecoin-project/litecoin that referenced this pull request Jul 17, 2012
guiutil.cpp/.h: fix a -Wreorder compiler warning...
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this pull request Dec 5, 2017
…NODE_SYNC_ENOUGH_PEERS (6 currently) peers at the same height as we are (bitcoin#1257)
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Jan 22, 2019
fix various clang warnings, mostly about crit section protection of various std structures, remove unnecessary block template allocation
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants