GUI: adapt user-experience from messagepage for verifymessagedialog#1308
Merged
laanwj merged 1 commit intobitcoin:masterfrom May 15, 2012
Diapolo:polish_verifymessage
Merged
GUI: adapt user-experience from messagepage for verifymessagedialog#1308laanwj merged 1 commit intobitcoin:masterfrom Diapolo:polish_verifymessage
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:polish_verifymessage
Conversation
Member
There was a problem hiding this comment.
I think "Verify Signed Message" is a good title, which simply states the action. "Dialog" is not a sensible word to end users unless they're UI designers.
Member
|
Apart from my small comment, ACK. |
…ML to source to avoid a problem with Qt < 4.7 / add eventFilter for address field to select text when clicking in / add Clear All button / rework strings
Author
|
Updated and rebased to reflect your comment. |
laanwj
added a commit
that referenced
this pull request
May 15, 2012
GUI: adapt user-experience from messagepage for verifymessagedialog
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
GUI: adapt user-experience from messagepage for verifymessagedialog
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
…#1308) 3 cleanups: do not create qa cache directory until the cache is complete, fix return check on compare_exchange_weak, point python logs to stdout so they are not interpreted as errors
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
1159df7 [zPIV] Public coin, a super for-each removed. (doing nothing..) (furszy) Pull request description: auto-descriptive title. Side from this, checked @random-zebra's PRs and didn't find this cleanup. If for some reason I missed it and it's inside one of the PRs, let me know and can close this PR. ACKs for top commit: random-zebra: Nice find. utACK 1159df7 Tree-SHA512: 8325ddd4c3de2c1f6a9e9c483720e7430539ef5e8e3e8fec309c366be82f0234944b22fb25e30c4b5402429b5b9f830be6ff6cbe3f409a32a0a42515214807ec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to discuss the strings once more, before we update the translation master file to not again get strings translated, that are not "final".
I really love that GUI feature and want to thank sje397 for his great work, which I only try to improve a little :).