Merged
Conversation
Github-Pull: bitcoin#14056 Rebased-From: 7d0a8ad
Github-Pull: bitcoin#14071 Rebased-From: faf4a9b
…not thread safe Github-Pull: bitcoin#14069 Rebased-From: 737670c
maflcko
force-pushed
the
Mf1808-017qabackports
branch
from
8fbcef4 to
cf3d7f9
Compare
Member
|
utACK cf3d7f9 |
laanwj
added a commit
that referenced
this pull request
Aug 28, 2018
cf3d7f9 Use assert when running from multithreaded code as BOOST_CHECK_* are not thread safe (Jesse Cohen) fab0fbe qa: Stop txindex thread before calling destructor (MarcoFalke) b5ec6d4 Docs: Fix help message typo optiona -> optional (Ben Woosley) Pull request description: Fixes to make the unit tests and bench pass with the thread sanitizer (beside the issue with fChecked #14058 (comment)). For testing: `./configure --with-sanitizers=undefined,thread && make -j 16 && ./src/test/test_bitcoin` Tree-SHA512: 5cb85ecc278b719dba03240265e93424ed1a28671834da7590adab88c2d43c6e6cbf3269bbe2fd79e5ed3a85ec77a268e05301e7a7421cf6a97d413dddac6327
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to make the unit tests and bench pass with the thread sanitizer (beside the issue with fChecked #14058 (comment)).
For testing:
./configure --with-sanitizers=undefined,thread && make -j 16 && ./src/test/test_bitcoin