Skip to content

fix default Proxy address in Qt options (no hostname allowed currently)#1418

Merged
sipa merged 1 commit intobitcoin:masterfrom
Diapolo:GUI_fix_default_proxy_addr
Jun 5, 2012
Merged

fix default Proxy address in Qt options (no hostname allowed currently)#1418
sipa merged 1 commit intobitcoin:masterfrom
Diapolo:GUI_fix_default_proxy_addr

Conversation

@Diapolo
Copy link
Copy Markdown

@Diapolo Diapolo commented Jun 4, 2012

This small glitch was introduced with #1389 and get's fixed with this pull.

The options page needs a rework and it would be nice, if @sipa could open a small issue on Github, which explains what needs to be added there.

sipa added a commit that referenced this pull request Jun 5, 2012
fix default Proxy address in Qt options (no hostname allowed currently)
@sipa sipa merged commit afdd594 into bitcoin:master Jun 5, 2012
coblee pushed a commit to litecoin-project/litecoin that referenced this pull request Jul 17, 2012
fix default Proxy address in Qt options (no hostname allowed currently)
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this pull request Dec 5, 2017
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Jan 22, 2019
* Turn graphene on by default

* Check for HaveNodes

* Handle edge case for requesting a full block.

Although very unlikely this edge case could happen if a node
decides not to run one of either thinblocks or graphene while at
the same time doesn't have either graphene peers or thinblock peers.

So for the following cases...

Graphene disable but Thinblock enabled, however there are graphene peers
but no thinblock peers connected.

or

Graphene enabled and Thinblocks disabled, however there are thinblock peers
but not graphene peers connected.

* indent only - no semantic changes

* Prelim refactor of ipaddress() in bitcoin tests

Remove the repeating code for defining ipaddress() in the bitcoin
tests. Just have a global definition rather than having to create
multiple but slightly different definitions.

* Add request manager tests for RequestBlock()

Make RequestBlock() public

Add helper functions to util.h: SetArg(), SetBoolArg()

Make GetTimeMillis() be useable if mocktime is set.  This is so we can test
the functionlity of the thinblock and graphene timers.

* Remove redundant checked for IsGraphenBlockEnabled()
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request May 6, 2020
8375bd8 [Tests] Use blocks v7 on regtest (random-zebra)
596902f [Core] Remove IsSuperMajority (random-zebra)
9cd2f81 [Consensus] Reject outdated blocks by enforcement height (random-zebra)

Pull request description:

  `IsSuperMajority` checks are slow, and not needed after enforcement.
  Also ISM is not a good mechanism for deployment, so will not likely be used again after BIP65.
  (based on bitcoin#8391)

  We should implement better fork signal/activation solutions such as [BIP 9](https://github.com/bitcoin/bips/blob/master/bip-0009.mediawiki) in the future.

  **Note:** testnet resync completed. currently checking resync on mainnet.

ACKs for top commit:
  furszy:
    Tested ACK 8375bd8
  Fuzzbawls:
    ACK 8375bd8

Tree-SHA512: 587b08ab25b92661a362494023d914af606acce5af8ddb9bd4f4f36dc9dd621c6d5dfbe2a530c73aab3e9c47af90a98ff319cd4116e72eff2fdb424f4df517bd
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants