Skip to content

When datadir missing, show messagebox instead of printing error to stderr#1905

Merged
laanwj merged 1 commit intobitcoin:masterfrom
laanwj:2012_10_startup_gui_error
Oct 5, 2012
Merged

When datadir missing, show messagebox instead of printing error to stderr#1905
laanwj merged 1 commit intobitcoin:masterfrom
laanwj:2012_10_startup_gui_error

Conversation

@laanwj
Copy link
Copy Markdown
Member

@laanwj laanwj commented Oct 4, 2012

For the GUI version...
As stderr and stdout point to the bit bucket in Windows for windowed applications, users get no error message.

@Diapolo
Copy link
Copy Markdown

Diapolo commented Oct 4, 2012

Also a good idea, but the strings could be translatable?

@laanwj
Copy link
Copy Markdown
Member Author

laanwj commented Oct 4, 2012

They can't. This check is done far before the translation system is initialized, as to support lang= in bitcoin.conf (which is in the data directory). The old message was also not translated, I've just put it in useful form for windows users.

@Diapolo
Copy link
Copy Markdown

Diapolo commented Oct 4, 2012

Right, didn't have that in my mind! ACK then.

@laanwj
Copy link
Copy Markdown
Member Author

laanwj commented Oct 4, 2012

We could eventually decide that bitcoin.conf contains core options and not GUI options (as we store GUI settings in QSettings now it's kind of pointless), but all changes in ordering have to be considered really carefully to not break anything.

@laanwj
Copy link
Copy Markdown
Member Author

laanwj commented Oct 4, 2012

I've added a comment to make this clear.

laanwj added a commit that referenced this pull request Oct 5, 2012
@laanwj
Merge pull request #1905 from laanwj/2012_10_startup_gui_error
a6be58d 
When datadir missing, show messagebox instead of printing error to stderr
@laanwj laanwj merged commit a6be58d into bitcoin:master Oct 5, 2012
@BitcoinPullTester
Copy link
Copy Markdown

BitcoinPullTester commented Oct 6, 2012

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/61fd72695f291a7a083cdc8ba96bda971c19eb53 for binaries and test log.

@laanwj laanwj deleted the 2012_10_startup_gui_error branch April 9, 2014 14:19
KolbyML pushed a commit to KolbyML/bitcoin that referenced this pull request Dec 5, 2020
@random-zebra
Merge bitcoin#1905: [Cleanup] removing unused mapRelay and cs_mapRelay.
ea5f85e 
e04d2bd Cleanup: removing unused mapRelay and cs_mapRelay. (furszy)

Pull request description:

  Cleaning the currently not unused `mapRelay` and `cs_mapRelay`. Making bitcoin#1786 obsolete.

ACKs for top commit:
  random-zebra:
    utACK e04d2bd
  Fuzzbawls:
    utACK e04d2bd

Tree-SHA512: ccbbec9f5e04995982e891191c844c3f81d4c06798d35f80ab52c0e07c05dd5ab15bf3a8c3e2476ae282794c00cb533ba807116142db0d455cf3791424ec5ab8
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laanwj @Diapolo @BitcoinPullTester