build: Drop ancient hack in gitian-linux descriptor #19622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theuni Mind reviewing this PR as it removes the code added by you? |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
My 2c: When I was writing the Guix scripts, I didn't include these hacks and the reproducibility worked out fine. I tried to build the Guix environment to be somewhat similar to the Ubuntu one, so I suspect this should work fine. |
|
NACKish on only the 1ba1496 commit
|
This hack is described in bitcoin#8188. The current implementation was introduced in bitcoin#8315.
|
Updated d3fe00d -> f9da969 (pr19622.01 -> pr19622.02, diff). Addressed @dongcarl's comment:
|
We need Python3 to run the security and symbol check scripts post build. I'd assume it's still being installed as a side-effect of another package. |
Virtual package 'binutils-gold' replaced with 'binutils'. Explicitly added 'patch' package.
Indeed. I forgot about |
hebasto
force-pushed
the
200729-multilib
branch
from
f9da969 to
33a84e8
Compare
|
Updated f9da969 -> 33a84e8 (pr19622.02 -> pr19622.03, diff). Addressed @fanquake's comment:
|
|
Code review ACK 33a84e8 |
My hashes for comparison: |
|
tACK 33a84e8 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 10, 2020
33a84e8 build: Update and sort package list in gitian-linux.yml (Hennadii Stepanov) 9505168 build: Drop old hack which is unneeded now (Hennadii Stepanov) Pull request description: The hack was aimed to fix an issue in Ubuntu Trusty 14.04 (see bitcoin#8188). The current hack implementation was added in bitcoin#8315. On master (8db2334) this hack is effectively noop, and it is no longer needed. I see this PR as a step to removing `libfaketime` from gitian builds. ACKs for top commit: dongcarl: tACK 33a84e8 laanwj: Code review ACK 33a84e8 Tree-SHA512: 90036c555a500649ccc3d108bf11f09a9cfd2c92c0b598f7e0c0df63a713ae7abaf78f350b68c025470619c967223f45f6a235ad37a6ce1d1a0341ed34963ba0
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Oct 23, 2021
33a84e8 build: Update and sort package list in gitian-linux.yml (Hennadii Stepanov) 9505168 build: Drop old hack which is unneeded now (Hennadii Stepanov) Pull request description: The hack was aimed to fix an issue in Ubuntu Trusty 14.04 (see bitcoin#8188). The current hack implementation was added in bitcoin#8315. On master (8db2334) this hack is effectively noop, and it is no longer needed. I see this PR as a step to removing `libfaketime` from gitian builds. ACKs for top commit: dongcarl: tACK 33a84e8 laanwj: Code review ACK 33a84e8 Tree-SHA512: 90036c555a500649ccc3d108bf11f09a9cfd2c92c0b598f7e0c0df63a713ae7abaf78f350b68c025470619c967223f45f6a235ad37a6ce1d1a0341ed34963ba0
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Oct 23, 2021
33a84e8 build: Update and sort package list in gitian-linux.yml (Hennadii Stepanov) 9505168 build: Drop old hack which is unneeded now (Hennadii Stepanov) Pull request description: The hack was aimed to fix an issue in Ubuntu Trusty 14.04 (see bitcoin#8188). The current hack implementation was added in bitcoin#8315. On master (8db2334) this hack is effectively noop, and it is no longer needed. I see this PR as a step to removing `libfaketime` from gitian builds. ACKs for top commit: dongcarl: tACK 33a84e8 laanwj: Code review ACK 33a84e8 Tree-SHA512: 90036c555a500649ccc3d108bf11f09a9cfd2c92c0b598f7e0c0df63a713ae7abaf78f350b68c025470619c967223f45f6a235ad37a6ce1d1a0341ed34963ba0
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Dec 4, 2021
33a84e8 build: Update and sort package list in gitian-linux.yml (Hennadii Stepanov) 9505168 build: Drop old hack which is unneeded now (Hennadii Stepanov) Pull request description: The hack was aimed to fix an issue in Ubuntu Trusty 14.04 (see bitcoin#8188). The current hack implementation was added in bitcoin#8315. On master (8db2334) this hack is effectively noop, and it is no longer needed. I see this PR as a step to removing `libfaketime` from gitian builds. ACKs for top commit: dongcarl: tACK 33a84e8 laanwj: Code review ACK 33a84e8 Tree-SHA512: 90036c555a500649ccc3d108bf11f09a9cfd2c92c0b598f7e0c0df63a713ae7abaf78f350b68c025470619c967223f45f6a235ad37a6ce1d1a0341ed34963ba0
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Dec 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hack was aimed to fix an issue in Ubuntu Trusty 14.04 (see #8188).
The current hack implementation was added in #8315.
On master (8db2334) this hack is effectively noop, and it is no longer needed.
I see this PR as a step to removing
libfaketimefrom gitian builds.