RPC: Forbid RPC username == RPC password #1987

Merged
merged 1 commit into from Nov 16, 2012

Projects

None yet

6 participants

@jgarzik
Bitcoin member

Added security measure.

@Diapolo

ACK, security measures are always a nice addition.

@gavinandresen
Bitcoin member

ACK

@sipa
Bitcoin member

I'm not sure this will help, but ACK.

@BitcoinPullTester

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/b1080c44840e8253ef353725e27a7626eb8a66df for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
2. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
3. The test suite fails on either Linux i386 or Win32
4. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

@TheBlueMatt

Sorry, that was a timeout due to slow jenkins server..., Ill get this retested (and fix the false negatives here)

Jeff Garzik RPC: Forbid RPC username == RPC password
Added security measure.
7e1610d
@jgarzik jgarzik merged commit 34ea321 into bitcoin:master Nov 16, 2012
@jgarzik jgarzik deleted the jgarzik:no-pw-match branch Aug 24, 2014
@jwrb jwrb referenced this pull request in PaycoinFoundation/paycoin Sep 22, 2015
Merged

RPC: Forbid RPC username == RPC password #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment