Skip to content

RPC: Forbid RPC username == RPC password#1987

Merged
jgarzik merged 1 commit intobitcoin:masterfrom
jgarzik:no-pw-match
Nov 16, 2012
Merged

RPC: Forbid RPC username == RPC password#1987
jgarzik merged 1 commit intobitcoin:masterfrom
jgarzik:no-pw-match

Conversation

@jgarzik
Copy link
Copy Markdown
Contributor

@jgarzik jgarzik commented Nov 5, 2012

Added security measure.

@Diapolo
Copy link
Copy Markdown

Diapolo commented Nov 5, 2012

ACK, security measures are always a nice addition.

@gavinandresen
Copy link
Copy Markdown
Contributor

ACK

@sipa
Copy link
Copy Markdown
Member

sipa commented Nov 5, 2012

I'm not sure this will help, but ACK.

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/b1080c44840e8253ef353725e27a7626eb8a66df for binaries and test log.

This could happen for one of several reasons:

  1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
  2. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
  3. The test suite fails on either Linux i386 or Win32
  4. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

@TheBlueMatt
Copy link
Copy Markdown
Contributor

Sorry, that was a timeout due to slow jenkins server..., Ill get this retested (and fix the false negatives here)

jgarzik pushed a commit that referenced this pull request Nov 16, 2012
RPC: Forbid RPC username == RPC password
@jgarzik jgarzik merged commit 34ea321 into bitcoin:master Nov 16, 2012
laudney pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request Mar 19, 2014
RPC: Forbid RPC username == RPC password
@jgarzik jgarzik deleted the no-pw-match branch August 24, 2014 04:19
KolbyML pushed a commit to KolbyML/bitcoin that referenced this pull request Dec 5, 2020
a0a061e [Tests] Add sapling_supply functional test (random-zebra)

Pull request description:

  Add basic test for the shielded pool value update, as suggested in PIVX-Project#1982 (review)

ACKs for top commit:
  furszy:
    Nice, code review ACK a0a061e
  Fuzzbawls:
    ACK a0a061e

Tree-SHA512: 01ab71e9fa916bf53284427a2d33de1842ce64ad0bcc26e083f883d0a75cec51e17e848749d9fef8d34038aba54725015f9c807620d2af275176fe6b32b68823
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants