use new message() function in BitcoinGUI#2045
use new message() function in BitcoinGUI#2045laanwj merged 1 commit intobitcoin:masterfrom Diapolo:use_message
Conversation
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/49d58d2d1b862112fa6a4f7fbfb45d726b023c25 for binaries and test log. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/8f824def5784ab9177803af9ce561e4ffd3a4eac for binaries and test log. |
There was a problem hiding this comment.
I wonder why we still have a mysterious boolean parameter for the 'modal' state, even though that's one of the CClientUIInterface flags? :-)
There was a problem hiding this comment.
I think the reason is in bitcoin.cpp ThreadSafeMessageBox(), where we first use the modal flag. I'm sure it could be removed, when I have time I'll take a look. Do you think this should block merging this pull then?
There was a problem hiding this comment.
Possibly. I think the current semantics is pretty vague. Some of the flags are usable, but not modal, because it's separated out to a different parameter. A pull request to change this would affect exactly the same areas as this one. So let's try to do it right in one go.
- use it for displaying URI parsing warnings - use it for displaying error and information in backup wallet function (the information display is new and the error was a warning before) - cleanup BitcoinGUI::incomingTransaction() -- use message() + the information icon from message -- comment out an unused parameter in the function definition and declaration -- move all pre-checks at the beginning of the function
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/50ecd7b68970062bfb540798370dbfab6d376086 for binaries and test log. |
|
@laanwj This should be sane now, it was rebased after the removal of the modal flag. |
There was a problem hiding this comment.
It IS :), as MSG_ERROR = (ICON_ERROR | BTN_OK | MODAL).
|
@laanwj Considered ready to get merged? |
|
@laanwj ping |
use new message() function in BitcoinGUI
use new message() function in BitcoinGUI
3 participants
(the information display is new and the error was a warning before)
-- use message() + the information icon from message
-- comment out an unused parameter in the function definition and
declaration
-- move all pre-checks at the beginning of the function
@laanwj There is this comment in qmessagebox.h (
// the following functions are obsolete) that lists the static QMessageBox functions (warning, information and so on) as obsolete, so I think we should talk about replacing them over the next months.