Display tx nLockTime correctly when set to block ##2159
Merged
gavinandresen merged 1 commit intobitcoin:masterfrom Jan 14, 2013
Merged
Display tx nLockTime correctly when set to block ##2159gavinandresen merged 1 commit intobitcoin:masterfrom
gavinandresen merged 1 commit intobitcoin:masterfrom
Conversation
Previously when a transaction was set to lock at a specific block the calculation was reversed, returning a negative number. This broke the UI and caused it to display %n in place of the actual number. In addition the previous calculation would display "Open for 0 blocks" when the block height was such that the next block created would finalize the transaction. Inserted the word "more" and changed the calculation so that the last message would be "Open for 1 more block" to better match user expectations.
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/10046e27dbc10270f59385231736da2a9a327a8f for binaries and test log. |
Member
|
Ack |
|
ACK |
gavinandresen
added a commit
that referenced
this pull request
Jan 14, 2013
Display tx nLockTime correctly when set to block #
laudney
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Mar 19, 2014
…ectly Display tx nLockTime correctly when set to block #
owlhooter
pushed a commit
to owlhooter/mazacoin-new
that referenced
this pull request
Oct 11, 2018
Merge develop 0.12.3.1 into master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when a transaction was set to lock at a specific block the calculation was reversed, returning a negative number. This broke the UI and caused it to display %n in place of the actual number.
In addition the previous calculation would display "Open for 0 blocks" when the block height was such that the next block created would finalize the transaction. Inserted the word "more" and changed the calculation so that the last message would be "Open for 1 more block" to better match user expectations.
If you don't feel invalidating the translations is worth it, let me know and I'll back that part of the change out.