Accept negative -par values to leave N CPUs free.#2349
Conversation
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/817abe0c4b89d743dab617fb1912a5317dc75b13 for binaries and test log. |
|
ACK |
|
ACK; needs a rebase, though. |
|
@sipa What about |
|
@Diapolo As long as we don't have good lock isolation, RPC processing is effectively single-threaded anyway. I don't even think there's any good reason for more than 2 RPC threads right now. |
|
@sipa AFAIK we currently use 4 RPC threads as default ;). I just was asking if these changes could be valuable for other thread-related command-line parameters also. |
|
Re "needs a rebase", am I supposed to do that? (my knowledge of git/github is pretty basic still) |
|
Ok, did the rebase, with help from @rdponticelli. |
|
Thanks. If you can squash the two commits together also, I'll merge. |
|
'twas easier to reset both diffs and commit a new one again ("easier" == "I've done it in the past" :)). |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/22192ca744892568dc8d68fcbcec5d6d0aaa8d2e for binaries and test log. |
Accept negative -par values to leave N CPUs free.
Accept negative -par values to leave N CPUs free.
Giving negative values to the -par parameter causes bitcoin to run with 1 verification thread. It can be useful to tell bitcoin to use all existing CPUs but leave e.g. 1 of them free for another tasks; this patch allows that by specifying -par=-1.