Skip to content

Accept negative -par values to leave N CPUs free.#2349

Merged
sipa merged 1 commit intobitcoin:masterfrom
dserrano5:master
Apr 29, 2013
Merged

Accept negative -par values to leave N CPUs free.#2349
sipa merged 1 commit intobitcoin:masterfrom
dserrano5:master

Conversation

@dserrano5
Copy link
Copy Markdown
Contributor

Giving negative values to the -par parameter causes bitcoin to run with 1 verification thread. It can be useful to tell bitcoin to use all existing CPUs but leave e.g. 1 of them free for another tasks; this patch allows that by specifying -par=-1.

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/817abe0c4b89d743dab617fb1912a5317dc75b13 for binaries and test log.

@gavinandresen
Copy link
Copy Markdown
Contributor

ACK

@sipa
Copy link
Copy Markdown
Member

sipa commented Apr 5, 2013

ACK; needs a rebase, though.

@Diapolo
Copy link
Copy Markdown

Diapolo commented Apr 6, 2013

@sipa What about -rpcthreads, does this make sense there too? Or for -genproclimit (which seems missing from our help message in init.cpp?)?

@sipa
Copy link
Copy Markdown
Member

sipa commented Apr 12, 2013

@Diapolo As long as we don't have good lock isolation, RPC processing is effectively single-threaded anyway. I don't even think there's any good reason for more than 2 RPC threads right now.

@Diapolo
Copy link
Copy Markdown

Diapolo commented Apr 12, 2013

@sipa AFAIK we currently use 4 RPC threads as default ;). I just was asking if these changes could be valuable for other thread-related command-line parameters also.

@dserrano5
Copy link
Copy Markdown
Contributor Author

Re "needs a rebase", am I supposed to do that? (my knowledge of git/github is pretty basic still)

@dserrano5
Copy link
Copy Markdown
Contributor Author

Ok, did the rebase, with help from @rdponticelli.

@sipa
Copy link
Copy Markdown
Member

sipa commented Apr 29, 2013

Thanks. If you can squash the two commits together also, I'll merge.

@dserrano5
Copy link
Copy Markdown
Contributor Author

'twas easier to reset both diffs and commit a new one again ("easier" == "I've done it in the past" :)).

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/22192ca744892568dc8d68fcbcec5d6d0aaa8d2e for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

sipa added a commit that referenced this pull request Apr 29, 2013
Accept negative -par values to leave N CPUs free.
@sipa sipa merged commit 228b29c into bitcoin:master Apr 29, 2013
laudney pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request Mar 19, 2014
Accept negative -par values to leave N CPUs free.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants