Skip to content

Bitcoin-Qt: fix GUI after initial multi-wallet patch#2452

Merged
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:Qt_fix_GUI
Apr 3, 2013
Merged

Bitcoin-Qt: fix GUI after initial multi-wallet patch#2452
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:Qt_fix_GUI

Conversation

@Diapolo
Copy link
Copy Markdown

@Diapolo Diapolo commented Apr 3, 2013

Bitcoin-Qt: fix GUI after initial multi-wallet patch
8726de2 
- adds 6 methods in BitcoinGUI to access some actions needed by the new
  WalletView class
- updates WalletView class to use these instead of trying to duplicate
  these
- cleanup walletview.{cpp/h} and remove all unneeded stuff
- this fixes problems with tabs toolbar (#2451) and export broken (#2436)
- more details in #2447
@BitcoinPullTester
Copy link
Copy Markdown

BitcoinPullTester commented Apr 3, 2013

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/8726de26ee0010eaf64d44d69cc9b8e09e580a37 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Apr 3, 2013

Thanks for the fixes!

@CodeShark Next time you should fix your own bugs :p

laanwj
laanwj reviewed Apr 3, 2013
View reviewed changes
Comment thread src/qt/bitcoingui.h
Copy link
Copy Markdown
Member

@laanwj laanwj Apr 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this can be done more elegantly with signals.
Then again, due to the nature of the bug fixes I'm going to merge this immediately.

Copy link
Copy Markdown
Author

@Diapolo Diapolo Apr 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a ToDo in my local build :).

laanwj added a commit that referenced this pull request Apr 3, 2013
@laanwj
Merge pull request #2452 from Diapolo/Qt_fix_GUI
7129c6e 
Bitcoin-Qt: fix GUI after initial multi-wallet patch
@laanwj laanwj merged commit 7129c6e into bitcoin:master Apr 3, 2013
laudney pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request Mar 19, 2014
@laanwj
Merge pull request bitcoin#2452 from Diapolo/Qt_fix_GUI
b5a4d30 
Bitcoin-Qt: fix GUI after initial multi-wallet patch
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Diapolo @BitcoinPullTester @laanwj