Skip to content

Require strictly-standard encodings in mempool#2520

Merged
gavinandresen merged 1 commit intobitcoin:masterfrom
sipa:strictmempool
Apr 15, 2013
Merged

Require strictly-standard encodings in mempool#2520
gavinandresen merged 1 commit intobitcoin:masterfrom
sipa:strictmempool

Conversation

@sipa
Copy link
Copy Markdown
Member

@sipa sipa commented Apr 13, 2013

This will make the mempool require strictly DER-encoded signatures, and restrict public keys to being either compressed or uncompressed (so no "hybrid" ones).

See the discussion here: http://comments.gmane.org/gmane.comp.bitcoin.devel/1973

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/20d0810f300fdcb6a0af6cb310c4702cdd956009 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@jgarzik
Copy link
Copy Markdown
Contributor

jgarzik commented Apr 13, 2013

ACK

1 similar comment
@laanwj
Copy link
Copy Markdown
Member

laanwj commented Apr 14, 2013

ACK

@petertodd
Copy link
Copy Markdown
Contributor

ACK

One reason I'd love to see canonical encodings mandated sooner rather than later is because they are going to make it a lot harder to write software for some of the really stripped down secure hardware stuff I'd like to see happen eventually. Many of these environments are downright anemic, smartcards for instance, so any fixed dependencies are a big problem.

gavinandresen added a commit that referenced this pull request Apr 15, 2013
Require strictly-standard encodings in mempool
@gavinandresen gavinandresen merged commit a3e7577 into bitcoin:master Apr 15, 2013
@sipa sipa deleted the strictmempool branch May 3, 2013 18:48
laudney pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request Mar 19, 2014
Require strictly-standard encodings in mempool
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants