Skip to content

Update bitcoin-qt.pro Brew patch to set OpenSSL lib paths#2655

Closed
fanquake wants to merge 1 commit intobitcoin:masterfrom
fanquake:brew-qt-pro-openssl
Closed

Update bitcoin-qt.pro Brew patch to set OpenSSL lib paths#2655
fanquake wants to merge 1 commit intobitcoin:masterfrom
fanquake:brew-qt-pro-openssl

Conversation

@fanquake
Copy link
Copy Markdown
Member

It's possible that OpenSSL might not be not linked correctly after installation via Brew, and if this hasn't been remedied with "brew force" then you could unknowingly be building with OSX's outdated OpenSSL.

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c63791170b55a5bcffc7e631fb42ef462706eb3a for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this doing here? Thought this is Mac OpenSSL related :).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Diapolo bitcoin-qt.pro has changed since I originally created the patch. So as well as adding the openssl lib defines, it brings the patch up to date.

@fanquake
Copy link
Copy Markdown
Member Author

Decided that this is essentially two separate issues that should be in separate pulls. Going to close this and open separate ones in the future.

@fanquake fanquake closed this Jun 23, 2013
@fanquake fanquake deleted the brew-qt-pro-openssl branch June 23, 2013 12:43
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants