Skip to content

Don't warn about forks while fIsInitialDownload#2968

Merged
gavinandresen merged 1 commit intobitcoin:masterfrom
TheBlueMatt:master
Sep 9, 2013
Merged

Don't warn about forks while fIsInitialDownload#2968
gavinandresen merged 1 commit intobitcoin:masterfrom
TheBlueMatt:master

Conversation

@TheBlueMatt
Copy link
Copy Markdown
Contributor

This is a cheap hack to address the warnings people get during initial download, feel free to discard in favor of something more reasonable.

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/c35d9c0952c41af08c48aab907d3aae1a2d8ee10 for binaries and test log.

This could happen for one of several reasons:

  1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in contrib/test-scripts)
  2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
  3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
  4. The test suite fails on either Linux i386 or Win32
  5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/55ed3f14751206fc87f0cbf8cb4e223efacef338 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@Diapolo
Copy link
Copy Markdown

Diapolo commented Sep 4, 2013

Seems reasonable...

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Sep 5, 2013

This will hide the warning, but is that the entire problem? will the block chain download continue?

@TheBlueMatt
Copy link
Copy Markdown
Contributor Author

The warning doesn't effect the download at all, and is generated sometimes when a "fork" is detected because we get blocks while we were in initial download.

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Sep 5, 2013

ACK in that case

@wtogami
Copy link
Copy Markdown
Contributor

wtogami commented Sep 8, 2013

ACK

gavinandresen added a commit that referenced this pull request Sep 9, 2013
Don't warn about forks while fIsInitialDownload
@gavinandresen gavinandresen merged commit 4c72384 into bitcoin:master Sep 9, 2013
Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Apr 8, 2020
* Merge bitcoin#8824: Refactor TxToJSON() and ScriptPubKeyToJSON()

0ff9320 refactor TxToJSON() and ScriptPubKeyToJSON() (jonnynewbs)

Tree-SHA512: caf7d590829e221522edd5b1ab8ce67b53a2c6986d3bbe8477eab420b1007bf60f885ed0a25ba9587e468c00768360ddc31db37847e862858573eaed5ed8b0d6

* remove witness and vsize

Signed-off-by: Pasta <Pasta@dash.org>

* Add valueSat

To preserve rpc output format

* Move extrapayload and special tx json output to `TxToUniv`

* Add spent index info
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants