Don't warn about forks while fIsInitialDownload#2968
Don't warn about forks while fIsInitialDownload#2968gavinandresen merged 1 commit intobitcoin:masterfrom
Conversation
|
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/c35d9c0952c41af08c48aab907d3aae1a2d8ee10 for binaries and test log. This could happen for one of several reasons:
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/55ed3f14751206fc87f0cbf8cb4e223efacef338 for binaries and test log. |
|
Seems reasonable... |
|
This will hide the warning, but is that the entire problem? will the block chain download continue? |
|
The warning doesn't effect the download at all, and is generated sometimes when a "fork" is detected because we get blocks while we were in initial download. |
|
ACK in that case |
|
ACK |
Don't warn about forks while fIsInitialDownload
* Merge bitcoin#8824: Refactor TxToJSON() and ScriptPubKeyToJSON() 0ff9320 refactor TxToJSON() and ScriptPubKeyToJSON() (jonnynewbs) Tree-SHA512: caf7d590829e221522edd5b1ab8ce67b53a2c6986d3bbe8477eab420b1007bf60f885ed0a25ba9587e468c00768360ddc31db37847e862858573eaed5ed8b0d6 * remove witness and vsize Signed-off-by: Pasta <Pasta@dash.org> * Add valueSat To preserve rpc output format * Move extrapayload and special tx json output to `TxToUniv` * Add spent index info
This is a cheap hack to address the warnings people get during initial download, feel free to discard in favor of something more reasonable.