Skip to content

Conversation

@sipa
Copy link
Member

@sipa sipa commented Dec 1, 2025

This brings doc/descriptors.md up to date:

  • Stop trying to exhaustively list all RPCs that involve descriptors. They're used everywhere.
  • Stop trying to give the history of descriptor support, we have release notes for that.
  • Mention that wallets are now built around descriptors (especially with legacy wallets gone).
  • Mention musig() KEY expressions in the specification part.
  • Reference the relevant output descriptor BIPs in the text.

@DrahtBot DrahtBot added the Docs label Dec 1, 2025
@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 1, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33986.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK rkrux, w0xlt

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

LLM Linter (✨ experimental)

Possible typos and grammar issues:

  • P2SH embed the argument. -> P2SH embeds the argument. [subject-verb agreement; "P2SH" (singular) requires "embeds"]
  • P2WSH embed the argument. -> P2WSH embeds the argument. [subject-verb agreement; "P2WSH" (singular) requires "embeds"]

2025-12-01

@fanquake
Copy link
Member

fanquake commented Dec 2, 2025

cc @Sjors

Copy link
Contributor

@rkrux rkrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ACK fc33626

Copy link
Contributor

@w0xlt w0xlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fc33626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants