wallet: skip APS when no partial spend exists #34362
Open
+56
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compute has_partial_spend inside CreateTransactionInternal using the available_coins that are already fetched for coin selection. This avoids a redundant AvailableCoins call compared to checking after the fact. The check determines if the selection spends some but not all UTXOs from any scriptPubKey. If no partial spend exists, APS cannot improve privacy, so we skip the second coin selection attempt entirely. Benefits: - Avoids unnecessary double coin selection when APS provides no benefit - Eliminates misleading tracepoint data - Prevents potential disimprovement of selection results - No extra AvailableCoins call (uses existing data) Add has_partial_spend field to CreatedTransactionResult to communicate this information from CreateTransactionInternal to CreateTransaction. Update interface_usdt_coinselection test to set up partial spend scenarios so APS tracepoints fire as expected. Fixes bitcoin#25150
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34362. ReviewsSee the guideline for information on the review process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the APS coin selection pass when the initial selection contains no partial
spend—APS cannot improve privacy in this case.
Detection compares selected vs available UTXO counts per scriptPubKey, reusing
available_coins. Test updated to create an actual partial spend scenario.Fixes #25150