scripted-diff: Rename WAIT_TIMEOUT to TEST_WAIT_TIMEOUT#34868
Merged
fanquake merged 1 commit intobitcoin:masterfrom Mar 20, 2026
Merged
scripted-diff: Rename WAIT_TIMEOUT to TEST_WAIT_TIMEOUT#34868fanquake merged 1 commit intobitcoin:masterfrom
WAIT_TIMEOUT to TEST_WAIT_TIMEOUT#34868fanquake merged 1 commit intobitcoin:masterfrom
Conversation
On Windows, the `winerror.h` header defines `WAIT_TIMEOUT` as a macro. This introduces a fragile dependency on header inclusion order: if Windows headers happen to be included before using `WAIT_TIMEOUT`, the preprocessor expands it into a numeric literal, causing syntax errors. Rename the variable to `TEST_WAIT_TIMEOUT` to remove this fragility and avoid the collision entirely. -BEGIN VERIFY SCRIPT- sed -i 's/\<WAIT_TIMEOUT\>/TEST_WAIT_TIMEOUT/g' $(git grep -l 'WAIT_TIMEOUT' ./src/) -END VERIFY SCRIPT-
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
w0xlt
reviewed
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the
winerror.hheader definesWAIT_TIMEOUTas a macro.This introduces a fragile dependency on header inclusion order: if Windows headers happen to be included before using
WAIT_TIMEOUT, the preprocessor expands it into a numeric literal, causing syntax errors.Rename the variable to
TEST_WAIT_TIMEOUTto remove this fragility and avoid the collision entirely.Split from #34448.
Similar to #34454.