Skip to content

[Qt] fix alphabetical ordering in Makefile.am#3513

Merged
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:makefile
Jan 12, 2014
Merged

[Qt] fix alphabetical ordering in Makefile.am#3513
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:makefile

Conversation

@Diapolo
Copy link
Copy Markdown

@Diapolo Diapolo commented Jan 11, 2014

  • also change to 1 file per line for more stuff in Makefile.am

@sipa
Copy link
Copy Markdown
Member

sipa commented Jan 11, 2014

ACK

Comment thread src/qt/Makefile.am
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot bitcoin.moc here.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, thanks for catching...

@sipa
Copy link
Copy Markdown
Member

sipa commented Jan 11, 2014

Undo ACK.

- also change to 1 file per line for more stuff in Makefile.am
@Diapolo
Copy link
Copy Markdown
Author

Diapolo commented Jan 12, 2014

Fixed missing bitcoin.moc.

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d464edfb8c4fe8415980614ceb95dff9bfadbf45 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

laanwj added a commit that referenced this pull request Jan 12, 2014
d464edf [Qt] fix alphabetical ordering in Makefile.am (Philip Kaufmann)
@laanwj laanwj merged commit d464edf into bitcoin:master Jan 12, 2014
@Diapolo Diapolo deleted the makefile branch January 12, 2014 10:45
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants