doc: clarify libfuzzer-nosan preset uses build_fuzz_nosan dir#35274
Open
ImMike wants to merge 1 commit into
Open
doc: clarify libfuzzer-nosan preset uses build_fuzz_nosan dir#35274ImMike wants to merge 1 commit into
ImMike wants to merge 1 commit into
Conversation
The fuzzing quickstart documents the libfuzzer preset with build_fuzz as the build directory, then mentions libfuzzer-nosan as an alternative without noting that this preset uses a different binary directory (build_fuzz_nosan, per CMakePresets.json). A reader following the quickstart with --preset=libfuzzer-nosan and then running 'cmake --build build_fuzz' as shown will operate against the wrong (or empty) directory. Add a note next to the first mention, and provide the corresponding nosan commands in the 'Run without sanitizers' section.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35274. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
l0rinc
reviewed
May 12, 2026
Contributor
l0rinc
left a comment
l0rinc
left a comment
There was a problem hiding this comment.
It's probably enough to mention it in a single place - concept ACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuzzing quickstart documents the
libfuzzerpreset withbuild_fuzzas the build directory, then mentionslibfuzzer-nosanas an alternative without noting that this preset uses a different binary directory (build_fuzz_nosan, perCMakePresets.json).A reader following the quickstart with
--preset=libfuzzer-nosanand then runningcmake --build build_fuzzas shown will operate against the wrong (or empty) directory.This PR:
build_fuzz_nosancommands.Pure docs; no code changes.