musig: Require generated secnonce for partial sig#35422
Open
nervana21 wants to merge 2 commits into
Open
Conversation
IsValid() reported allocated secure memory, which is true for every default-constructed object. Record successful CreateMuSig2Nonce in m_has_nonce, clear it in Invalidate(), and have IsValid() report that flag. Return nullopt from CreateMuSig2PartialSig when generation has not yet succeeded. Add a bip328 unit test for the generate-sign-invalidate lifecycle.
IsValid() on keys and pubkeys typically checks that the key material is well-formed. HasNonce() reports whether CreateMuSig2Nonce has succeeded.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35422. ReviewsSee the guideline for information on the review process. |
Contributor
Author
Member
|
It shouldn't be possible to hit any error with this as the nonce is not stored if nonce generation fails. Instead of a bool that needs to track state, the unique ptr can be created in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per BIP327, a
secnonceconsisting of only zero bytes is invalid for Sign and will cause it to fail.Previously,
MuSig2SecNonce::IsValid()only reported whether secure memory was allocated for thesecnonce, not whetherCreateMuSig2Noncehad succeeded in creating thesecnonce.This patch tracks successful
secnoncegeneration, rejectsCreateMuSig2PartialSigwhen generation has not succeeded, renames the query method toHasNonce, and adds a regression test.Test plan
/build/bin/test_bitcoin --run_test=bip328_tests/secnonce_lifecycle