qt: allow walletpassphrase in debug console without -server#3553
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jan 23, 2014
Merged
qt: allow walletpassphrase in debug console without -server#3553laanwj merged 1 commit intobitcoin:masterfrom
walletpassphrase in debug console without -server#3553laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Currently it is only possible to use `walletpassphrase` to unlock the wallet when bitcoin is started in server mode. Almost everything that manipulates the wallet in the RPC console needs the wallet to be unlocked and is thus unusable without -server. This is pretty unintuitive to me, and I'm sure it's even more confusing to users. Solve this with a very minimal change: by making the GUI start a dummy RPC thread just to handle timeouts.
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a8db31c83d6a43e07f741f7f61b1bf0df87621c7 for binaries and test log. |
Member
|
ACK |
laanwj
added a commit
that referenced
this pull request
Jan 23, 2014
a8db31c qt: allow `walletpassphrase` in debug console without -server (Wladimir J. van der Laan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is only possible to use
walletpassphraseto unlock the wallet when bitcoin is started in server mode.Almost everything that manipulates the wallet in the RPC console (for example, importprivkey) needs the wallet to be unlocked and is thus unusable without -server.
This is pretty unintuitive to me, and I'm sure it's even more confusing to users.
Solve this with a very minimal change: by making the GUI start a dummy RPC thread just to handle deadline timers.