Conversation
There were some problems with the existing testing setup: - Makefile rules for test-file compilation used CFLAGS instead of CXXFLAGS in makefile.unix - Main test file included other test files verbatim using #include - Test files included bitcoin headers using #include "../foo.h" (this breaks when headers include other headers), so add -I. to the flags to make #include "foo.h" include the top-level foo.h. (Only tested on Linux)
This is needed for the script unit tests.
|
Nice! Thanks! |
|
Looks cool, however the -I. stuff kills MinGW building, so NACK that part. |
|
Is there a standard makefile syntax for "the directory that the makefile is in" ? (it has been many years since I wrestled with makefiles....) |
|
vegard: ping? I'd very much like to pull this, will you have time soon to fix the mingw and undefined symbol problems? |
|
On 18 July 2011 03:06, gavinandresen
I'm not sure what to do about them. I don't have windows or mingw, and I can try to have a look next week. |
|
I'd suggest jumping on IRC and see if you can recruit somebody to help test/fix... (BlueMatt is very helpful). |
|
Pulled versions of these, Matt fixed them up. |
bump debian package version.
…gitian keys 4c72d1f remove midnight's gitian signing key from list of gitian keys (Midnight Magic) Pull request description: as per subject.. ACKs for top commit: domob1812: ACK 4c72d1f. Tree-SHA512: 5cd18ad676c5ff01c194734a3c2c2257850c10e61d8a8b5fabc4423c8ebcfce9f25d03d0fc222b16c64bdac3c7395e4fc075e77afccd082c01ff3888dd3536d5
Node Operations - Submarine Swap
3 participants
I made some changes in anticipation of unit tests for scripts and OP_CHECKSIG, etc.
Feedback is welcome.