Replace PrintException with PrintExceptionContinue + throw#3749
Merged
laanwj merged 1 commit intobitcoin:masterfrom Feb 26, 2014
Merged
Replace PrintException with PrintExceptionContinue + throw#3749laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Just a pet peeve. (PrintException has exactly the same body as PrintExceptionContinue but does a re-throw at the end. Move these re-throws to the call site, this aids understanding what is going on as well as eliminates a bit of code duplication in util.cpp)
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/44235713ed0ad1810328f21108d32bbac04de87b for binaries and test log. |
Contributor
|
Easy ACK :) |
Contributor
|
ACK |
laanwj
added a commit
that referenced
this pull request
Feb 26, 2014
4423571 Replace PrintException with PrintExceptionContinue + throw (Wladimir J. van der Laan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a pet peeve (@cozz likely agrees).
(PrintException has exactly the same body as PrintExceptionContinue but does a re-throw at the end. Move these re-throws to the call site, this aids understanding what is going on as well as eliminates a
bit of code duplication in util.cpp)