Skip to content

qt: Show weeks as well as years behind for long timespans#3876

Merged
laanwj merged 1 commit intobitcoin:masterfrom
laanwj:2014_03_qt_years_weeks_behind
Mar 15, 2014
Merged

qt: Show weeks as well as years behind for long timespans#3876
laanwj merged 1 commit intobitcoin:masterfrom
laanwj:2014_03_qt_years_weeks_behind

Conversation

@laanwj
Copy link
Copy Markdown
Member

@laanwj laanwj commented Mar 15, 2014

Four years looks slightly nicer than 208 weeks.

weeks

Closes #3811.

@laanwj laanwj mentioned this pull request Mar 15, 2014
@felipelalli
Copy link
Copy Markdown

ship it!

@laanwj
Copy link
Copy Markdown
Member Author

laanwj commented Mar 15, 2014

Have you tested?

@felipelalli
Copy link
Copy Markdown

No, I am sorry. Just code review. I am setting up the environment to start to contribute. I am reading all READMEs, and I read that I can contribute with code review and also test, which is the current bottleneck. Should I test carefully every change before send a "ship it"? Even theses small changes? Thank you for help.

@laanwj
Copy link
Copy Markdown
Member Author

laanwj commented Mar 15, 2014

Nah, it's not super important in this case. I ask just in case, I usually feel better merging something when someone else has at least tested it (even minor changes like this). Thanks for trying to contribute!

@felipelalli
Copy link
Copy Markdown

Thank you @laanwj ! I hope to get everything over time.

@haakonn
Copy link
Copy Markdown
Contributor

haakonn commented Mar 15, 2014

ACK.

I tested this using 'bitcoin-qt --reindex' under Qt4/Ubuntu. Seems to work as advertised, and I really like it! The only change that arguably could be an improvement would be to simplify "3 years and 0 weeks behind" to simply "3 years behind". But that's a minor thing and I think this is mergeable as is.

laanwj added a commit that referenced this pull request Mar 15, 2014
a1465ac qt: Show weeks as well as years behind for long timespans (Wladimir J. van der Laan)
@laanwj laanwj merged commit a1465ac into bitcoin:master Mar 15, 2014
@laanwj laanwj deleted the 2014_03_qt_years_weeks_behind branch April 9, 2014 14:02
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants