Parameterise command line option defaults, so translations are independent of them#5076
Conversation
|
utACK |
src/init.cpp
Outdated
There was a problem hiding this comment.
Please parametrize only the '1' here, that makes for an easier translation message
There was a problem hiding this comment.
Does it? "0 if no -proxy or -connect" doesn't really make sense :/
There was a problem hiding this comment.
See it from this angle: making people translate a message as a fragment that will be inserted as-is into another message is just pointless.
There was a problem hiding this comment.
If the default changes, only that part will be invalidated in the translations, not the entire description?
There was a problem hiding this comment.
Why would that be better? In both cases you have to re-translate one message. But in the case of the fragment it makes much less sense to the translator.
|
ACK apart from the nits |
luke-jr
force-pushed
the
notranslate_defaults
branch
from
9b5946d to
0a08aa8
Compare
|
That is better, but I'm missing constants to replace those default values in the code! |
src/init.cpp
Outdated
There was a problem hiding this comment.
Not your mistake, but I only notice this now: this should be '1 if no <mode> specified'. Let's leave default out of this. If 1 would really be the default, it would always do a zapwallettxes operation!
|
Making constants makes more discussion. Let's do that in a follow-up PR after this is merged. |
|
Why? Just because you want to hurry ;). |
|
Because it's better to do things in small steps so there's less to rebase when one part of it prompts months of discussions. And this gets one improvement out there sooner if the other one pushes past a release. There's nothing inherently related about variablising stuff here. |
|
Agree with @luke-jr here. Right now this is an extremely low-impact change, and reviewing is limited to the documentation only. If you were to make constants and use those it is more work to verify that everything is unchanged. |
|
Tested ACK |
4 participants
No description provided.