minor style cleanup after HTTP rest interface merge#5309
Merged
laanwj merged 2 commits intobitcoin:masterfrom Nov 24, 2014
Diapolo:cleanup
Merged
minor style cleanup after HTTP rest interface merge#5309laanwj merged 2 commits intobitcoin:masterfrom Diapolo:cleanup
laanwj merged 2 commits intobitcoin:masterfrom
Diapolo:cleanup
Conversation
Diapolo
commented
Nov 19, 2014
Diapolo
commented
- no code changes
Member
There was a problem hiding this comment.
Why make this one wide line with the comment after it? That's harder to read IMO. Please at least keep the comment above the function definition.
Member
|
|
Member
|
oh, never mind, don't do that, this touches different files... |
Contributor
|
ACK everything except the rpcserver change. |
Author
|
@jgarzik Done :). |
added 2 commits
November 20, 2014 12:29
Author
|
@laanwj Should be uncontroversial now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.