Add unconfirmedbalance field to getwalletinfo#5522
Closed
esotericnonsense wants to merge 1 commit intobitcoin:masterfrom
Closed
Add unconfirmedbalance field to getwalletinfo#5522esotericnonsense wants to merge 1 commit intobitcoin:masterfrom
esotericnonsense wants to merge 1 commit intobitcoin:masterfrom
Conversation
Member
|
@azeteki Do you want to close you pull now that gmaxwell has added your commit to #5540? |
Contributor
|
accidentally superseded by #5540. |
Member
|
Merged through #5540. |
Contributor
Author
|
Apologies for the delay in replying/failure to close! I seem to remember chatting to gmaxwell about this on IRC so it may be that we just duplicated work. A ten second change anyway. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default behaviour of RPC 'getbalance' is to exclude unconfirmed wallet transactions in the balance calculation.
There exists an additional RPC command 'getunconfirmedbalance' which returns only the sum of incoming unconfirmed transactions.
This patch adds an 'unconfirmedbalance' field to getwalletinfo, reducing the need for additional RPC queries. The functionality is equivalent to 'getunconfirmedbalance'.
I have tested this patch on testnet and it works as expected.