Skip to content

Use real text rather than image-rendered text for unit selector#5551

Merged
laanwj merged 1 commit intobitcoin:masterfrom
luke-jr:no_txt_img
Jan 2, 2015
Merged

Use real text rather than image-rendered text for unit selector#5551
laanwj merged 1 commit intobitcoin:masterfrom
luke-jr:no_txt_img

Conversation

@luke-jr
Copy link
Copy Markdown
Member

@luke-jr luke-jr commented Dec 27, 2014

The width of each unit is measured to set a fixed width for the widget, and the color is set to match the other status widgets.

@jonasschnelli
Copy link
Copy Markdown
Contributor

Nice. Tested.

ACK.

@Diapolo
Copy link
Copy Markdown

Diapolo commented Dec 28, 2014

Plese post some screens, I don't want to compile it if it looks just better ;).

@jonasschnelli
Copy link
Copy Markdown
Contributor

@Diapolo doesn't look really different to the current solution, just without ugly bitmap images.

@luke-jr
Copy link
Copy Markdown
Member Author

luke-jr commented Dec 29, 2014

@cozz Care to test/ACK since you had put in images with #4466 ?

@jonasschnelli
Copy link
Copy Markdown
Contributor

OSX 10.10 screenshot:
bildschirmfoto 2014-12-29 um 10 56 20

The width of each unit is measured to set a fixed width for the widget, and the color is set to match the other status widgets.
@zander
Copy link
Copy Markdown

zander commented Dec 29, 2014

utACK

@jgarzik jgarzik added the GUI label Dec 31, 2014
@cozz
Copy link
Copy Markdown
Contributor

cozz commented Jan 2, 2015

Looks good on my desktop:

KDE
archi1
archi2

Fluxbox
archibald64
archibald642

@laanwj laanwj merged commit dd3f697 into bitcoin:master Jan 2, 2015
laanwj added a commit that referenced this pull request Jan 2, 2015
dd3f697 Use real text rather than image-rendered text for unit selector (Luke Dashjr)
@luke-jr luke-jr deleted the no_txt_img branch January 2, 2015 14:53
@Diapolo
Copy link
Copy Markdown

Diapolo commented Jan 3, 2015

Is this missing an update to our assets file?

langerhans pushed a commit to langerhans/dogecoin that referenced this pull request Feb 15, 2015
patricklodder added a commit to dogecoin/dogecoin that referenced this pull request Mar 7, 2015
Merge bitcoin/bitcoin#5551 for a better looking unit selection in the statusbar
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants