[QT] minor UI updates

[jonasschnelli]

I cumulate changes to avoid having to many PRs:

1. I resized the transaction icon in the overview page a little bit and changed the amount of transaction from 3 to 5. Otherwise there is always blank space at the bottom.
2. To avoid the double frame issue in sendcoins / sendcoinsentry (recipient box) i replace the inner frame with a horizontal line.
3. Use warning icons instead of "(out of sync)" text in overview page
4. Don't colorize icons on win/mac

EDIT: added point 4

Screens from current master

Double frame issue:

Empty space:

[jonasschnelli]

Added another change on the top (cumulating changes to avoid another blizzard of PRs):

• use warning icons instead of "(out of sync)" text.

Looks like:

[ddehueck]

This looks really good. The only suggestions I have would be to make the icon red and the tooltip state that the synchronization process could take awhile if the user is synchronizing for the first time. Thoughts?

[jonasschnelli]

@essofluffy: IMO red is the color of errors. Yellow would be appropriate. But since i started with black, flat icons (#5219) i would say black is fine and it would avoid rainbow color software.

[ddehueck]

@jonasschnelli That PR had some good discussion so I'll concede on the color of the icon. Black will work just fine.

[jonasschnelli]

Added another commit:

• use always black icons on Mac and Win

[ghost]

utAck, I like tooltips for verbiage, but the icon looks really blended in with the text, I'm not sure a user would notice it has additional information if hovered over.

[ddehueck]

@jonasschnelli Did you make these icons?

[jonasschnelli]

Did you make these icons?

@essofluffy: no, check: https://github.com/jonasschnelli/bitcoin/blob/2015/05/qt_polish_1/doc/assets-attribution.md#typiconsstephen-hutchings

[...] I'm not sure a user would notice it has additional information if hovered over.

I have to agree. Placing the text "(out of sync)" next to the icon would be a option. Other ideas?

[ghost]

I have to agree. Placing the text "(out of sync)" next to the icon would be a option. Other ideas?

Typically the visual cue i look for in a tooltip is a little (?) but i think this tooltip "cue" can really be basically anything.. dashed underlines i've seen before too.

[ddehueck]

Maybe something like, (out of sync, hover for more info)?

[sipa]

Concept ACK

[jonasschnelli]

@essofluffy @faizkhan00 : i don't think we should tell the user "hover for more information". It's somehow uncommon.
I think the current solution is almost okay. What it misses if a reaction when you click on the new "warning" icon. There ist should open a alert with the out of since information text (same as tooltip). I'll try to add this soon.

[ghost]

@jonasschnelli Hmm, yeah looking over the images I think this is reasonable too, I'm correct in assuming those icons disappear once the blockchain is fully synced up, as well?

[ddehueck]

@faizkhan00 your assumption would be correct.

[jonasschnelli]

@fanquake: would you agree with 3) if the icon would be clickable then showing a info-alert with the extended out-of-sync information?

What about 4)? (#6110 (comment))

[laanwj]

ACK

[fanquake]

@jonasschnelli ACK 4 as well. If consensus is that 3 is an improvement, then lets get this merged.

[luke-jr]

Concept ACK

Significant issue: point 2 results in less recipients visible in sendcoins dialog.

Nits/preferred changes:

• Overview recent txs should grow with window size.
• Warning icon maybe ought to be red?

[laanwj]

@luke-jr Icon color has been already discussed above, IMO it's fine like this. It is not a very dangerous warning, we don't want to unnecessarily light up the overview page like a christmas tree.

[jonasschnelli]

@luke-jr

Significant issue: point 2 results in less recipients visible in sendcoins dialog.

The new sendcoinsentries are some pixels higher. But it depends on you window height. So i think this is not very urgent.

Overview recent txs should grow with window size.

Agreed. But this would be a different PR

Warning icon maybe ought to be red?

As @laanwj said. See above. IMO red makes only sense for errors.

[luke-jr]

@jonasschnelli I don't get the point of making sendcoinsentry taller. It doesn't depend on window height - no matter what height is used, less now fits in it.

[jonasschnelli]

@luke-jr: Okay. The top/bottom margin could be better. I try to solve it and will see if i get ~the same height.

[jonasschnelli]

@luke-jr: I did optimize the sendcoinsentry height. Check the comparison screenshot (open the image url in a new tab/window to get full resolution).

I hope this PR makes it into 0.11!

[luke-jr]

Tested ACK

[laanwj]

I wonder if this will cause code-unreachable warnings, may be better to #else #ifdef the rest of the function, same for SingleColorIcon.

[jonasschnelli]

Agreed. It's kinda stupid to try to compile code after return.

Fixed.

[laanwj]

Posthumous nit: the warning icon doesn't get the color of the other single-color icons, it is black even on Linux

[jonasschnelli]

Oh. Right. Will fix this.

[luke-jr]

@laanwj I wouldn't expect it to? Looks like it really ought to be a considered part of the text now. :)

[laanwj]

@luke-jr Fine with me. But then it should color with the text, currently it is always black.

[luke-jr]

Oh, I forgot sometimes text isn't black :)

I wonder if we should just make a font for our single-colour icons at this point? (assuming Qt lets you use Unicode characters for icons... which it might not)

[laanwj]

Using a font for the icons would be a neat and modern solution. Could put the icons in the Private Use Area, and use them accordingly in (rich)text. I also proposed it in the beginning when the single-color-icons were introduced. Technically it could be somewhat more of a challenge, though - I don't know Qt-Custom-Font-Handling specifics. No desperate need though, that's the realm of 'far future would be nice'. E.g. no more custom code would be needed to color the icons.

[jonasschnelli]

Most of the "new" icons are available as font (typicon font). But handling a font on three platform is probably much more complex the handling PNG files.
A font would be really nice because it's vector based. On the other hand it could introduce antialiasing issues (blurring) different margin/paddings on different systems. IMO a font would probably add more issues then I potentially could solve.