Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce ambiguity of warning message #9088

Merged
merged 1 commit into from Nov 8, 2016
Merged

Reduce ambiguity of warning message #9088

merged 1 commit into from Nov 8, 2016

Conversation

rebroad
Copy link
Contributor

@rebroad rebroad commented Nov 5, 2016

Fixes #9079

@fanquake fanquake added the GUI label Nov 5, 2016
@kazcw
Copy link
Contributor

kazcw commented Nov 5, 2016

This helps a lot with the ambiguity, but users who have already seen the message will tend to read just the beginning, so I think it should start with a summary of the situation as the old message (sort of) did. What about phrasing the first sentence more like "Your wallet is not finished synchronizing with the bitcoin network." to lead with status information rather than exposition.

@maflcko
Copy link
Member

maflcko commented Nov 5, 2016

Thanks! Concept ACK.

@jonasschnelli
Copy link
Contributor

Thanks!
ACK 26f2cb1c9c739002ea74afbb7b333f794c2d7cfd

@fanquake
Copy link
Member

fanquake commented Nov 6, 2016

ACK 26f2cb1

@rebroad
Copy link
Contributor Author

rebroad commented Nov 6, 2016 •
edited

@kazcw I see your point. I have rearranged the message now to put the more pertinent information first. @jonasschnelli @fanquake Are your previous ACKs valid for this new wording?

@rebroad rebroad force-pushed the LessAmbiguousWalletWarning branch 2 times, most recently from 5d8217e to 3e77259 Compare November 6, 2016 07:44
@maflcko
Copy link
Member

maflcko commented Nov 6, 2016

utACK 77cbbd9

@rebroad
Copy link
Contributor Author

rebroad commented Nov 6, 2016

Why is travis complaining?

@crowning- crowning- mentioned this pull request Nov 6, 2016
Merged
@laanwj
Copy link
Member

laanwj commented Nov 7, 2016 •
edited

Unrelated, likely (issue #8842):

p2p-segwit.py                  | False  | 74 s

@laanwj
Copy link
Member

laanwj commented Nov 8, 2016

utACK 77cbbd9

This helps a lot with the ambiguity, but users who have already seen the message will tend to read just the beginning

Luckily there will not be many users that have already seen the message, as it's not in any release yet.

@laanwj laanwj merged commit 77cbbd9 into bitcoin:master Nov 8, 2016
laanwj added a commit that referenced this pull request Nov 8, 2016
@laanwj
Merge #9088: Reduce ambiguity of warning message
4e57824 
77cbbd9 Make warning message about wallet balance possibly being incorrect less ambiguous. (R E Broadley)
@rebroad rebroad mentioned this pull request Jan 4, 2017
Merged
codablock pushed a commit to codablock/dash that referenced this pull request Sep 8, 2017
@laanwj @codablock
Merge bitcoin#9088: Reduce ambiguity of warning message
ba6bf73 
77cbbd9 Make warning message about wallet balance possibly being incorrect less ambiguous. (R E Broadley)
UdjinM6 pushed a commit to dashpay/dash that referenced this pull request Sep 9, 2017
@codablock @UdjinM6
Backport Bitcoin Qt/Gui changes up to 0.14.x part 2 (#1615)
9707ca5 
* Merge bitcoin#7506: Use CCoinControl selection in CWallet::FundTransaction

d6cc6a1 Use CCoinControl selection in CWallet::FundTransaction (João Barbosa)

* Merge bitcoin#7732: [Qt] Debug window: replace "Build date" with "Datadir"

fc737d1 [Qt] remove unused formatBuildDate method (Jonas Schnelli)
4856f1d [Qt] Debug window: replace "Build date" with "Datadir" (Jonas Schnelli)

* Merge bitcoin#7707: [RPC][QT] UI support for abandoned transactions

8efed3b [Qt] Support for abandoned/abandoning transactions (Jonas Schnelli)

* Merge bitcoin#7688: List solvability in listunspent output and improve help

c3932b3 List solvability in listunspent output and improve help (Pieter Wuille)

* Merge bitcoin#8006: Qt: Add option to disable the system tray icon

8b0e497 Qt: Add option to hide the system tray icon (Tyler Hardin)

* Merge bitcoin#8073: qt: askpassphrasedialog: Clear pass fields on accept

02ce2a3 qt: askpassphrasedialog: Clear pass fields on accept (Pavel Vasin)

* Merge bitcoin#8231: [Qt] fix a bug where the SplashScreen will not be hidden during startup

b3e1348 [Qt] fix a bug where the SplashScreen will not be hidden during startup (Jonas Schnelli)

* Merge bitcoin#8257: Do not ask a UI question from bitcoind

1acf1db Do not ask a UI question from bitcoind (Pieter Wuille)

* Merge bitcoin#8463: [qt] Remove Priority from coincontrol dialog

fa8dd78 [qt] Remove Priority from coincontrol dialog (MarcoFalke)

* Merge bitcoin#8678: [Qt][CoinControl] fix UI bug that could result in paying unexpected fee

0480293 [Qt][CoinControl] fix UI bug that could result in paying unexpected fee (Jonas Schnelli)

* Merge bitcoin#8672: Qt: Show transaction size in transaction details window

c015634 qt: Adding transaction size to transaction details window (Hampus Sjöberg)
 \-- merge fix for s/size/total size/
fdf82fb Adding method GetTotalSize() to CTransaction (Hampus Sjöberg)

* Merge bitcoin#8371: [Qt] Add out-of-sync modal info layer

08827df [Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul (Jonas Schnelli)
d8b062e [Qt] only update "amount of blocks left" when the header chain is in-sync (Jonas Schnelli)
e3245b4 [Qt] add out-of-sync modal info layer (Jonas Schnelli)
e47052f [Qt] ClientModel add method to get the height of the header chain (Jonas Schnelli)
a001f18 [Qt] Always pass the numBlocksChanged signal for headers tip changed (Jonas Schnelli)
bd44a04 [Qt] make Out-Of-Sync warning icon clickable (Jonas Schnelli)
0904c3c [Refactor] refactor function that forms human readable text out of a timeoffset (Jonas Schnelli)

* Merge bitcoin#8805: Trivial: Grammar and capitalization

c9ce17b Trivial: Grammar and capitalization (Derek Miller)

* Merge bitcoin#8885: gui: fix ban from qt console

cb78c60 gui: fix ban from qt console (Cory Fields)

* Merge bitcoin#8821: [qt] sync-overlay: Don't block during reindex

fa85e86 [qt] sync-overlay: Don't show estimated number of headers left (MarcoFalke)
faa4de2 [qt] sync-overlay: Don't block during reindex (MarcoFalke)

* Support themes for new transaction_abandoned icon

* Fix constructor call to COutput

* Merge bitcoin#7842: RPC: do not print minping time in getpeerinfo when no ping received yet

62a6486 RPC: do not print ping info in getpeerinfo when no ping received yet, fix help (Pavel Janík)

* Merge bitcoin#8918: Qt: Add "Copy URI" to payment request context menu

21f5a63 Qt: Add "Copy URI" to payment request context menu (Luke Dashjr)

* Merge bitcoin#8925: qt: Display minimum ping in debug window.

1724a40 Display minimum ping in debug window. (R E Broadley)

* Merge bitcoin#8972: [Qt] make warnings label selectable (jonasschnelli)

ef0c9ee [Qt] make warnings label selectable (Jonas Schnelli)

* Make background of warning icon transparent in modaloverlay

* Merge bitcoin#9088: Reduce ambiguity of warning message

77cbbd9 Make warning message about wallet balance possibly being incorrect less ambiguous. (R E Broadley)

* Replace Bitcoin with Dash in modal overlay

* Remove clicked signals from labelWalletStatus and labelTransactionsStatus

As both are really just labels, clicking on those is not possible.
This is different in Bitcoin, where these labels are actually buttons.

* Pull out modaloverlay show/hide into it's own if/else block and switch to time based check

Also don't use masternodeSync.IsBlockchainSynced() for now as it won't
report the blockchain being synced before the first block (or other MN
data?) arrives. This would otherwise give the impression that sync is
being stuck.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ambiguous message: "spending bitcoins may not be possible"
6 participants
@rebroad @kazcw @maflcko @jonasschnelli @fanquake @laanwj