Fix Large Font Accessibility issues on icons on Vault and Send#1785
Merged
Fix Large Font Accessibility issues on icons on Vault and Send#1785
Conversation
…for Icons Display #1774
Closed
1 task
mpbw2
approved these changes
Feb 17, 2022
fedemkr
added a commit
that referenced
this pull request
Feb 25, 2022
* master: (82 commits) Autosync the updated translations (#1812) Apply Disable Favicon setting globally to match desktop (#1811) Fix for missing bio unlock on app restart (#1810) Changed link on Settings "Change Master Password" and "Two Step Login" to go to the web vault settings. Also refactored a bit to reuse the urls (#1809) take environment into account when checking for existing account (#1808) Account Switching (#1807) Fixes incorrect path in workflow (#1806) [BEEEP] - Added workflows to ignored paths (#1802) Add dry run option to release workflow (#1801) Changed Input keyboard on phone to be the telephone keyboard and also capitalized the keyboard on some fields of add/edit identity (#1800) Fix Options being seen in two lines on Add/edit Send (#1798) Fix icon image size to be adaptive on Large Font Size Accessibility which fixes row height on large vault (#1795) We're Hiring (#1797) Moved to new Google Service Account (#1789) Moved to new Google Service Account (#1788) Move to using shared workflow (#1787) Autosync the updated translations (#1786) Fixed some Large Font Accessibility issues on Vault and Send screens for Icons Display #1774 (#1785) Created initial workflow for workflow linting (#1783) Enforce Hold label (#1779) ... # Conflicts: # src/App/Pages/Accounts/DeleteAccountViewModel.cs # src/App/Pages/Settings/ExportVaultPageViewModel.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This PR fixes the Large Font Accessibility issues on the Vault and Send views, that were displaying the icons partially when the system font was too big.
Code changes
GetSystemFontSizeScale()to calculate sizes that are not directly related to fonts like grid columns.ShouldUpdateFontSizeDynamicallyForAccesibilityto be specific on when we want to update the font size for accesibility. This was added just in case to not affect the whole app thus introducing this change little by little. Then when we address the Accessibillity Large Font issues across the whole app we can make the logic more generic and remove this property.IconLabelwithShouldUpdateFontSizeDynamicallyForAccesibilityset totrueUIFontfrom aIFontElementScreenshots
Testing requirements
On the Vault and Send tabs, the rows should be shown correctly without clipping the icons when changing the Accessibility Large Fonts from the system settings.
Known issue: On iOS, for web icons you may not see the update on size if you don't close the app and open it again after changing the Large Font settings. This will be addressed in a different PR
Before you submit