Skip to content

Add dry run option to release workflow#1801

Merged
mimartin12 merged 3 commits intomasterfrom
dryrun-workflow
Feb 23, 2022
Merged

Add dry run option to release workflow#1801
mimartin12 merged 3 commits intomasterfrom
dryrun-workflow

Conversation

@mimartin12
Copy link
Copy Markdown

@mimartin12 mimartin12 commented Feb 23, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

We would like the ability to test the majority of the functionality of our release pipelines so that we can release faster.

Code changes

  • .github/workflows/release.yml: Adds dry run options and gates. Updates action versions, which is a good test for dry-run

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

- Adds dry run options and gates
- Updates action versions, which is a good test for dry-run
@mimartin12 mimartin12 requested a review from a team February 23, 2022 14:09
@mimartin12 mimartin12 marked this pull request as ready for review February 23, 2022 14:13
@mimartin12 mimartin12 self-assigned this Feb 23, 2022
Copy link
Copy Markdown

@joseph-flinn joseph-flinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@mimartin12
Copy link
Copy Markdown
Author

mimartin12 commented Feb 23, 2022

@mimartin12 mimartin12 merged commit 4722d2f into master Feb 23, 2022
@mimartin12 mimartin12 deleted the dryrun-workflow branch February 23, 2022 14:48
fedemkr added a commit that referenced this pull request Feb 25, 2022
* master: (82 commits)
  Autosync the updated translations (#1812)
  Apply Disable Favicon setting globally to match desktop (#1811)
  Fix for missing bio unlock on app restart (#1810)
  Changed link on Settings "Change Master Password" and "Two Step Login" to go to the web vault settings. Also refactored a bit to reuse the urls (#1809)
  take environment into account when checking for existing account (#1808)
  Account Switching (#1807)
  Fixes incorrect path in workflow (#1806)
  [BEEEP] - Added workflows to ignored paths (#1802)
  Add dry run option to release workflow (#1801)
  Changed Input keyboard on phone to be the telephone keyboard and also capitalized the keyboard on some fields of add/edit identity (#1800)
  Fix Options being seen in two lines on Add/edit Send (#1798)
  Fix icon image size to be adaptive on Large Font Size Accessibility which fixes row height on large vault (#1795)
  We're Hiring (#1797)
  Moved to new Google Service Account (#1789)
  Moved to new Google Service Account (#1788)
  Move to using shared workflow (#1787)
  Autosync the updated translations (#1786)
  Fixed some Large Font Accessibility issues on Vault and Send screens for Icons Display #1774 (#1785)
  Created initial workflow for workflow linting (#1783)
  Enforce Hold label (#1779)
  ...

# Conflicts:
#	src/App/Pages/Accounts/DeleteAccountViewModel.cs
#	src/App/Pages/Settings/ExportVaultPageViewModel.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants