Apply Disable Favicon setting globally to match desktop#1811
Merged
Conversation
fedemkr
reviewed
Feb 24, 2022
Comment on lines
+584
to
+602
| public async Task ApplyDisableFaviconGloballyAsync(bool? value) | ||
| { | ||
| // TODO remove this method (ApplyDisableFaviconGloballyAsync) to restore per-account icon support | ||
| await CheckStateAsync(); | ||
| if (_state?.Accounts == null) | ||
| { | ||
| return; | ||
| } | ||
| var activeUserId = await GetActiveUserIdAsync(); | ||
| foreach (var account in _state.Accounts) | ||
| { | ||
| var uid = account.Value?.Profile?.UserId; | ||
| // skip active user (theme already set) | ||
| if (uid != null && uid != activeUserId) | ||
| { | ||
| await SetDisableFaviconAsync(value, uid); | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This is using almost the same code as Task ApplyThemeGloballyAsync(string value). We could refactor a bit to share some more code, given that the only thing that changes is the call in the if; like a method that has a Task as a parameter that will be triggered in there
Contributor
Author
There was a problem hiding this comment.
Took a slightly different approach to keep everything contained within StateService
Member
There was a problem hiding this comment.
I really like the new approach 😄
fedemkr
approved these changes
Feb 24, 2022
fedemkr
added a commit
that referenced
this pull request
Feb 25, 2022
* master: (82 commits) Autosync the updated translations (#1812) Apply Disable Favicon setting globally to match desktop (#1811) Fix for missing bio unlock on app restart (#1810) Changed link on Settings "Change Master Password" and "Two Step Login" to go to the web vault settings. Also refactored a bit to reuse the urls (#1809) take environment into account when checking for existing account (#1808) Account Switching (#1807) Fixes incorrect path in workflow (#1806) [BEEEP] - Added workflows to ignored paths (#1802) Add dry run option to release workflow (#1801) Changed Input keyboard on phone to be the telephone keyboard and also capitalized the keyboard on some fields of add/edit identity (#1800) Fix Options being seen in two lines on Add/edit Send (#1798) Fix icon image size to be adaptive on Large Font Size Accessibility which fixes row height on large vault (#1795) We're Hiring (#1797) Moved to new Google Service Account (#1789) Moved to new Google Service Account (#1788) Move to using shared workflow (#1787) Autosync the updated translations (#1786) Fixed some Large Font Accessibility issues on Vault and Send screens for Icons Display #1774 (#1785) Created initial workflow for workflow linting (#1783) Enforce Hold label (#1779) ... # Conflicts: # src/App/Pages/Accounts/DeleteAccountViewModel.cs # src/App/Pages/Settings/ExportVaultPageViewModel.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Make the "Disable Website Icons" option global to match desktop. I'm continuing to follow the
Apply*Globallypattern established with the Theme change so a single block of code can be removed to restore per-account functionality in the future.Code changes
SetValueGloballyAsyncmethod to support key/value based settings (values not in theAccountobject)Apply*Globalcalls since everything is contained withinStateServicenowTesting requirements
https://app.asana.com/0/1201803072708593/1201880420113232
Before you submit