Fix vault item icon image size to be adaptive on Large Font Size Accessibility#1795
Merged
Fix vault item icon image size to be adaptive on Large Font Size Accessibility#1795
Conversation
…hich fixes row height on large vault
jlf0dev
reviewed
Feb 22, 2022
| var fontScale = ServiceContainer.Resolve<IDeviceActionService>("deviceActionService").GetSystemFontSizeScale(); | ||
| _iconColumn.Width = new GridLength(40 * fontScale, GridUnitType.Absolute); | ||
| _iconImage.WidthRequest = 22 * fontScale; | ||
| _iconImage.HeightRequest = 22 * fontScale; |
Member
There was a problem hiding this comment.
Does this 22 need to be the same value as the original WidthRequest and HeightRequest? If so, we should consider putting it in a const or grabbing the value from _iconColumn before using it.
Member
Author
There was a problem hiding this comment.
Yes, exactly I'm using the original WidthRequest and HeightRequest. I'll put it in a cost, we can't grab it from _iconColumn (unless we do the math proportion: 40/22=1.82 => _iconImage.WidthRequest = _iconColumn.Width.PropetyForTheActualValue / 1,82 but we'd need a const here as well and it's simpler with the 22 const) 😄 . I'll make the change
* master: We're Hiring (#1797)
jlf0dev
approved these changes
Feb 22, 2022
fedemkr
added a commit
that referenced
this pull request
Feb 25, 2022
* master: (82 commits) Autosync the updated translations (#1812) Apply Disable Favicon setting globally to match desktop (#1811) Fix for missing bio unlock on app restart (#1810) Changed link on Settings "Change Master Password" and "Two Step Login" to go to the web vault settings. Also refactored a bit to reuse the urls (#1809) take environment into account when checking for existing account (#1808) Account Switching (#1807) Fixes incorrect path in workflow (#1806) [BEEEP] - Added workflows to ignored paths (#1802) Add dry run option to release workflow (#1801) Changed Input keyboard on phone to be the telephone keyboard and also capitalized the keyboard on some fields of add/edit identity (#1800) Fix Options being seen in two lines on Add/edit Send (#1798) Fix icon image size to be adaptive on Large Font Size Accessibility which fixes row height on large vault (#1795) We're Hiring (#1797) Moved to new Google Service Account (#1789) Moved to new Google Service Account (#1788) Move to using shared workflow (#1787) Autosync the updated translations (#1786) Fixed some Large Font Accessibility issues on Vault and Send screens for Icons Display #1774 (#1785) Created initial workflow for workflow linting (#1783) Enforce Hold label (#1779) ... # Conflicts: # src/App/Pages/Accounts/DeleteAccountViewModel.cs # src/App/Pages/Settings/ExportVaultPageViewModel.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fix icon image size to be adaptive on Large Font Size Accessibility which also fixes the row height being really high on large vault items.
Code changes
Screenshots
Before:
After:
Testing requirements
Test that the icons have the correct size and check this on large vault as well.
Before you submit