Coldstake redeem bug#396
Merged
Merged
Conversation
Member
Author
|
Still need to fix the tests |
Member
Author
|
This is now ready to review, I will run tests locally. |
Member
Author
|
closes #395 |
Member
Author
|
All tests passed locally |
Member
Author
|
@sondreb reminder to review |
sondreb
approved these changes
Apr 27, 2022
sondreb
left a comment
sondreb
left a comment
Member
There was a problem hiding this comment.
Looks good, have not run and verified, but read all the changes.
Member
Author
|
I believe @miladsoft has tested it as well is that correct? |
Member
|
Yes, I have tested it and I am using it And it works properly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a cold stake bug found recently where hot/cold keys are use in more then one redeem script
#395