Remove old venv

[nicoschmdt]

No description provided.

[github-actions]

Automated PR Review

0. Summary

• Verdict: MINOR SUGGESTIONS ✏️

Removes the core/python-venv2 "secondary" virtualenv and consolidates every service under the primary uv workspace. All services now target the newer pinned dependency set (pydantic 2.12.5, aiohttp 3.13.2, fastapi 0.125.0, uvicorn 0.38.0, loguru 0.7.3, packaging 25.0, psutil 7.1.3), the pre-push hook and Dockerfile lose their primary/secondary bookkeeping, and the last pydantic v1/v2 compatibility shim in commonwealth is dropped. Well-scoped cleanup — only a couple of style nits worth flagging.

2. AGENTS.md Adherence

• 2.1 [minor] core/pyproject.toml:6-24 — the new workspace entries in dependencies (filebrowser, ardupilot_manager, bag_of_holding, beacon, bridget, ...) are appended in the same free-form order they had in the deleted python-venv2/pyproject.toml rather than being sorted. AGENTS.md rule Cable guy #1 explicitly states > Always sort dependencies alphabetically. Please interleave with bridges/commonwealth and sort the whole block (e.g. ardupilot_manager, bag_of_holding, beacon, bridges, bridget, cable_guy, commander, commonwealth, customization, disk_usage, filebrowser, helper, kraken, nmea_injector, pardal, ping, recorder_extractor, versionchooser, wifi).
• 2.2 [minor] core/pyproject.toml:38-58 — same problem in [tool.uv.sources]. Sort those workspace mappings alphabetically to match the same rule.

6. Code Quality & Style

• 6.1 [nit] core/libs/commonwealth/pyproject.toml:16 — every dependency in this file has been tightened to a single exact version (aiohttp==3.13.2, packaging==25.0, psutil==7.1.3, etc.), but starlette>=0.27.0 is left as an open-ended lower-bound range. If the intent is "pin everything to the resolved version", pin starlette too; otherwise this is fine to leave as-is since starlette is really a transitive dep of fastapi.

8. Documentation

• 8.1 [nit] core/services/kraken/manifest/models.py:59 — not touched by this PR, but note that under the newly-unified pydantic 2.12.5 the file still uses the deprecated @validator("compatible", pre=True, always=True) decorator. It runs (with a PydanticDeprecatedSince20 warning) because kraken was already on v2 via the old secondary venv, so this is not a regression from this PR. Worth queueing a follow-up to migrate to @field_validator("compatible", mode="before") before it disappears in pydantic 3.

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.