Skip to content

Cable guy - #1

Merged
patrickelectric merged 1 commit into
bluerobotics:masterfrom
patrickelectric:cable-guy
Aug 17, 2020
Merged

Cable guy#1
patrickelectric merged 1 commit into
bluerobotics:masterfrom
patrickelectric:cable-guy

Conversation

@patrickelectric

@patrickelectric patrickelectric commented Aug 5, 2020

Copy link
Copy Markdown
Member
  • Needs final test

@patrickelectric
patrickelectric marked this pull request as ready for review August 7, 2020 16:12
@patrickelectric
patrickelectric requested a review from jaxxzer August 7, 2020 16:12
Comment thread services/cable_guy/api/manager.py Outdated
Comment thread services/cable_guy/api/manager.py
Comment thread services/cable_guy/api/manager.py
Comment thread services/cable_guy/html/index.html Outdated
Comment thread services/cable_guy/html/index.html Outdated
Comment thread services/cable_guy/html/index.html
Comment thread services/cable_guy/html/index.html
Comment thread services/cable_guy/html/index.html
def index():
return open('html/index.html', 'r').read()

# Flask CORS appears to be not working anymore with connexion

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CORS will also be irrelevant in the final product, I think nginx can take that over

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but at least with this we can run only the service without dealing with CORS.

Comment thread services/cable_guy/api/settings.py
@patrickelectric

Copy link
Copy Markdown
Member Author

ping @Williangalvani

Comment thread services/cable_guy/html/index.html Outdated
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric

Copy link
Copy Markdown
Member Author

ping @Williangalvani

2 similar comments
@patrickelectric

Copy link
Copy Markdown
Member Author

ping @Williangalvani

@patrickelectric

Copy link
Copy Markdown
Member Author

ping @Williangalvani

@patrickelectric
patrickelectric merged commit 1cb346c into bluerobotics:master Aug 17, 2020
@github-actions github-actions Bot mentioned this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants