Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application Layout Framework #1732

Merged
merged 39 commits into from
Jan 9, 2024
Merged

Application Layout Framework #1732

merged 39 commits into from
Jan 9, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Oct 20, 2023 •
edited
Loading

ALF

gaearon
gaearon reviewed Oct 27, 2023
View reviewed changes
src/view/nova/lib/theme.ts Outdated Show resolved Hide resolved
gaearon
gaearon reviewed Oct 27, 2023
View reviewed changes
src/view/nova/lib/theme.ts Outdated Show resolved Hide resolved
@estrattonbailey
Merge remote-tracking branch 'origin/main' into eric/nova
0eb2065 
* origin/main: (22 commits)
  basic public RSS feed for profiles (#2229)
  use `s.likeColor` everywhere (#2234)
  Add credits to localization doc (#2233)
  Fix `Logotype` fill for dark mode (#2230)
  Hide label appeal on self-labeled posts (#2232)
  Fix & Add: Japanese Translation (3) (#2226)
  tweak social card meta yet again (#2228)
  bskyweb: update golang indigo dep (from May!), and some small devex tweaks (#2227)
  Fix: Some display issues (#2219)
  Update splash screen tagline, update translations, bump ios build number
  Bump ios build number
  Tweaks (#2225)
  1.60
  Traffic reduction and tuned caching strats (#2215)
  Super secret changes don't look (#2218)
  Fix android icon dims (#2213)
  Log post creation failures (#2205)
  Some brand, some pwi (#2212)
  🤫  (#2211)
  PWI behavior updates (#2207)
  ...
@estrattonbailey
Tweak colors, bit of cleanup
f427862
@estrattonbailey
Improve macro handling
2ee4528
@estrattonbailey
Add some more examples
c18bdfa
@estrattonbailey
Rename for better diff
c52ebff
gaearon
gaearon reviewed Dec 19, 2023
View reviewed changes
src/alf/lib/theme.ts Outdated Show resolved Hide resolved
gaearon
gaearon reviewed Dec 19, 2023
View reviewed changes
src/alf/lib/theme.ts Outdated Show resolved Hide resolved
gaearon
gaearon reviewed Dec 19, 2023
View reviewed changes
src/alf/lib/theme.ts Outdated Show resolved Hide resolved
gaearon
gaearon reviewed Dec 19, 2023
View reviewed changes
src/alf/lib/theme.ts Outdated Show resolved Hide resolved
@estrattonbailey
Fix typo
fe48217
@estrattonbailey
Some renaming
4f4a3ef
@estrattonbailey
More complete pass at Tailwind naming
c58a4d0
@estrattonbailey
Merge remote-tracking branch 'origin/main' into eric/nova
af5c048 
* origin/main: (67 commits)
  Localize options in "Thread Preferences" screen (#2373)
  Bump ios build number and android version code
  Remove the KeyboardAvoidingView in account creation (close #2333) (#2366)
  1.62
  Create account tweaks (#2365)
  Fix sizing of the leftnav new post btn (#2248)
  Use memory caching for android lightbox (#2354)
  Disable page-transition animations on android (#2352)
  Disable BlurView on android (#2351)
  Handle birth dates as UTC, handle locale formatting (#2363)
  Fix desktop styles a bit
  Disable spanish translation until it's more thoroughly reviewed (#2362)
  minor search screen ux improvements (#2264)
  Temporarily disable the german translation (#2360)
  Web dropdowns (#2358)
  Mark more text as translatable (#2284)
  Remove patched color scheme code (#2340)
  support multiple og:image tags (#2305)
  Fix missing avatar moderation in replies (#2325)
  Fixes to feed load triggers (#2323)
  ...
@estrattonbailey
Build out storybook
c328892
@estrattonbailey
Playing around with curves
6b0e0e5
@estrattonbailey
Revert "Playing around with curves"
85ebfc9 
This reverts commit 6b0e0e5.
@estrattonbailey
Smooth brain
1162d38
@estrattonbailey
Remove outdated docs
d73be62
@estrattonbailey estrattonbailey marked this pull request as ready for review January 4, 2024 18:42
@pfrazee pfrazee added the improvement Not quite a feature but improves existing behavior label Jan 8, 2024
@estrattonbailey
Merge remote-tracking branch 'origin' into eric/nova
4a52825 
* origin: (45 commits)
  Fix splash config (#2452)
  convert prefix to lowercase in actor autocomplete query (#2431)
  support intl tenor links (#2438)
  Splash: reduce motion + dark mode (#2448)
  Bump android app version code
  Don't use mask for android at all (#2445)
  Update Korean localization (#2432)
  Use android mode, fix fallback (#2437)
  Update for Version 1.63 Português (BR) (#2435)
  New translations messages.po (Ukrainian) (#2422)
  Update Japanese localization (addition + language code correction) (#2423)
  1.63
  Additional embed sources and external-media consent controls (#2424)
  Reduce web requests (#2420)
  New user home feed fixes (#2421)
  E2E runner fixes (#2428)
  Recompile all locales (#2411) (#2416)
  Add Ukrainian localization (#2336)
  Update Portuguese for Português (#2414)
  Add Portuguese Localization (#2407)
  ...
@pfrazee pfrazee self-assigned this Jan 9, 2024
pfrazee
pfrazee approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work getting this to the finish line. I'm pretty happy with the outcome here. Good to go

src/alf/index.tsx Show resolved Hide resolved
@estrattonbailey estrattonbailey merged commit a5b4748 into main Jan 9, 2024
4 checks passed
pull bot pushed a commit to imax9000/bsky-app-ua that referenced this pull request Jan 12, 2024
@estrattonbailey @pull
Application Layout Framework (bluesky-social#1732)
21c17d6 
* Initial library setup

* Add docblocks

* Some cleanup

* New storybook

* Playing around

* Remove silly test, use for...in

* Memo

* Memo

* Add hooks example

* Tweak colors, bit of cleanup

* Improve macro handling

* Add some more examples

* Rename for better diff

* Cleanup

* Add nested context example

* Add todo

* Less break more perf

* Buttons, you get the idea

* Fix test

* Remove temp colors

* Add a few more common macros

* Docs

* Perf improvements

* Alf go brrrr

* Update breakpoint handling

* I think it'll work

* Better naming, better code

* Fix typo

* Some renaming

* More complete pass at Tailwind naming

* Build out storybook

* Playing around with curves

* Revert "Playing around with curves"

This reverts commit 6b0e0e5.

* Smooth brain

* Remove outdated docs

* Some docs, fix line-height values, export tokens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon left review comments

@pfrazee pfrazee pfrazee approved these changes

Assignees

@pfrazee pfrazee

Labels
improvement Not quite a feature but improves existing behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estrattonbailey @gaearon @pfrazee