[CI] Move PHPStan and Composer Validate from Travis to Github Actions#1916
Merged
bobdenotter merged 2 commits intobolt:masterfrom Sep 28, 2020
Merged
[CI] Move PHPStan and Composer Validate from Travis to Github Actions#1916bobdenotter merged 2 commits intobolt:masterfrom
bobdenotter merged 2 commits intobolt:masterfrom
Conversation
TomasVotruba
commented
Sep 28, 2020
Comment on lines
+4
to
+7
|
|
||
| paths: | ||
| - src | ||
|
|
Contributor
Author
There was a problem hiding this comment.
It's best practise to have paths in configs, because it's now impossible to forget them. They're always used :)
Contributor
Author
|
Ready to merge ✔️ |
bobdenotter
approved these changes
Sep 28, 2020
Member
bobdenotter
left a comment
bobdenotter
left a comment
There was a problem hiding this comment.
Looks good, @TomasVotruba 👍
Merging this one and #1917 in!
bobdenotter
added
the
topic: DX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1912