Skip to content

[CI] Move PHPStan and Composer Validate from Travis to Github Actions #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobdenotter merged 2 commits into from
Sep 28, 2020
Merged

[CI] Move PHPStan and Composer Validate from Travis to Github Actions #1916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d181cf
[CI] Move PHPStan from Travis to Github Actions
TomasVotruba Sep 28, 2020
8bf0699
[CI] Move Composer Validate from Travis to Github Actions
TomasVotruba Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/code_analysis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@ jobs:
# tip: add "--ansi" to commands in CI to make them full of colors
run: vendor/bin/ecs check src --ansi

-
name: PHPStan
run: vendor/bin/phpstan analyse

# check that the composer.json and composer.lock files are valid
-
name: Composer Validate
run: composer validate --strict

name: ${{ matrix.actions.name }}
runs-on: ubuntu-latest

Expand Down
5 changes: 0 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ before_script:
- export PATH=$PATH:$PWD/vendor/bin

script:
# this checks that the source code follows the Bolt Code Syntax rules
- ./vendor/bin/phpstan analyse -c phpstan.neon src
# run EsLint on Javascript files
- npm run lint
# run StyleLint on SCSS
Expand All @@ -62,8 +60,6 @@ script:
- ./bin/console lint:xliff translations
# this checks that the application doesn't use dependencies with known security vulnerabilities
- ./bin/console security:check
# this checks that the composer.json and composer.lock files are valid
- composer validate --strict
# this checks that Doctrine's mapping configurations are valid
- ./bin/console doctrine:schema:validate --skip-sync -vvv --no-interaction
# run PHP Unit
Expand All @@ -74,4 +70,3 @@ script:
- travis_retry make db-reset-without-images && make behat-js-quiet
# Upload Behat logs
- ./vendor/bin/upload-textfiles "var/log/behat-reports/*.log"

4 changes: 4 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
parameters:
tmpDir: var/cache/ecs
level: 5

paths:
- src

Comment on lines +4 to +7
Copy link
Copy Markdown
Contributor Author

@TomasVotruba TomasVotruba Sep 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best practise to have paths in configs, because it's now impossible to forget them. They're always used :)

symfony:
container_xml_path: '%rootDir%/../../../var/cache/dev/Bolt_KernelDevDebugContainer.xml'

Expand Down