Skip to content

Fix AttitudeFactor Wrapping - #2500

Merged
dellaert merged 2 commits into
developfrom
fix/AttitudeFactorWrap
Apr 14, 2026
Merged

Fix AttitudeFactor Wrapping#2500
dellaert merged 2 commits into
developfrom
fix/AttitudeFactorWrap

Conversation

@dellaert

Copy link
Copy Markdown
Member

I now use the template mechanism in wrap to generate the Python class names. The typedefs in C++ are omitted. I also updated documentation and copilot instructions.

@dellaert
dellaert requested a review from varunagrawal April 12, 2026 20:47
@github-actions

Copy link
Copy Markdown

timeSFMBAL benchmark

  • Head: 1970e19bbcab19c5e7a15ead5b7bc98c7b96e21e
  • Base: e471c700760292ea0de8c7ef08f351a3b5d7c0a5
Runner Metric Base (s) Head (s) Delta (s) Change
linux-arm64-tbbOFF timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalCholesky 10.026695 9.679108 -0.347587 -3.47%
linux-arm64-tbbOFF timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalSolver 13.133864 12.836982 -0.296882 -2.26%
linux-arm64-tbbON timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalCholesky 5.205818 5.454743 +0.248925 +4.78%
linux-arm64-tbbON timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalSolver 9.361278 9.417347 +0.056069 +0.60%
linux-x64-tbbOFF timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalCholesky 10.937339 10.889717 -0.047622 -0.44%
linux-x64-tbbOFF timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalSolver 17.509015 17.628001 +0.118986 +0.68%
linux-x64-tbbON timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalCholesky 7.153008 6.936363 -0.216646 -3.03%
linux-x64-tbbON timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalSolver 14.957995 14.762470 -0.195525 -1.31%
macos-arm64-tbbOFF timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalCholesky 33.095213 34.726417 +1.631204 +4.93%
macos-arm64-tbbOFF timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalSolver 23.825840 19.287495 -4.538344 -19.05%
macos-arm64-tbbON timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalCholesky 48.673760 36.972631 -11.701129 -24.04%
macos-arm64-tbbON timeSFMBAL/dubrovnik-135-90642-pre.txt/MultifrontalSolver 20.261074 17.092964 -3.168110 -15.64%

Worker runs

Role Runner SHA Conclusion
head linux-x64 1970e19bbcab19c5e7a15ead5b7bc98c7b96e21e success
base linux-x64 e471c700760292ea0de8c7ef08f351a3b5d7c0a5 success
head linux-arm64 1970e19bbcab19c5e7a15ead5b7bc98c7b96e21e success
base linux-arm64 e471c700760292ea0de8c7ef08f351a3b5d7c0a5 success
head macos-arm64 1970e19bbcab19c5e7a15ead5b7bc98c7b96e21e success
base macos-arm64 e471c700760292ea0de8c7ef08f351a3b5d7c0a5 success

@dellaert dellaert mentioned this pull request Apr 13, 2026
@dellaert
dellaert merged commit 80b623c into develop Apr 14, 2026
41 checks passed
@dellaert
dellaert deleted the fix/AttitudeFactorWrap branch April 14, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant