Require unshallow clone to publish in SBT#3070
Merged
jackkoenig merged 1 commit intomainfrom Mar 4, 2023
Merged
Conversation
seldridge
approved these changes
Mar 3, 2023
| </licenses>, | ||
| sonatypeCredentialHost := "s01.oss.sonatype.org", | ||
| sonatypeRepository := "https://s01.oss.sonatype.org/service/local", | ||
| publish / skip := { |
Member
There was a problem hiding this comment.
It seems a little weird to use skip as a hook to error. You may want to add a comment indicating that this is what is going on here.
Contributor
Author
There was a problem hiding this comment.
Oh yeah I meant to add a comment and totally forgot. Yeah there isn't like a "publishing hook" key so I arbitrarily picked this, definitely needs to be explained.
jackkoenig
force-pushed
the
require-unshallow-to-publish
branch
from
add508d to
e92e35f
Compare
jackkoenig
added
the
Internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now if you try to publish from a shallow clone, it will error. This check would've helped detect #3069.