Error when calling .viewAs on non-hardware#3398
Merged
jackkoenig merged 3 commits intomainfrom Jun 29, 2023
Merged
Conversation
It's an error in most cases already, and in the cases it isn't, make it a warning. Also fix a crash that could occur when viewing a non-Data containing non-hardware Data.
This was previously deprecated, and in most cases results in an error downstream anyway.
jackkoenig
commented
Jun 29, 2023
| new DataView[T, V2]( | ||
| t => g.mkView(mkView(t)), | ||
| { case (t, v2) => List(t.viewAs[V](tdp, self).viewAs[V2](vdp, g) -> v2) }, | ||
| { case (t, v2) => List(t.viewAs[V].viewAs[V2] -> v2) }, |
Contributor
Author
There was a problem hiding this comment.
When I added source info as an implicit argument to .viewAs it told me I need to pass it explicitly here (which is true) but I realized that it would be simpler just to mark the two DataViews as implicit. When I originally wrote this I think I thought there would be ambiguity issues with the implicit DataViews but there obviously isn't because they are of different types. I added the type annotations just to make it more clear.
seldridge
approved these changes
Jun 29, 2023
jackkoenig
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #3395 and should be merged afterward
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.5.x,3.6.x, or5.xdepending on impact, API modification or big change:6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.