[scalatest] More conservative testdir mangling #4975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the way that test directory names are mangled to be much more conservative. Mangle ny character which isn't a letter, number, or underscore/dash. This was empirically observed to be needed for Verilator v5.038 by @ngraybeal. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
- Allow period, too.
seldridge
deleted the
dev/seldridge/scalatest-conservative-directory-mangle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the way that test directory names are mangled to be much more
conservative. Mangle ny character which isn't a letter, number, or
underscore/dash.
This was empirically observed to be needed for Verilator v5.038 by
@ngraybeal.
Release Notes
scalatest.TestingDirectorydirectory name mangling to be very conservative. Now, mangle anything not a letter, number, underscore, or dash. This is overly conservative, but avoids a whack-a-mole problem with Verilator. This has been empirically needed for Verilator v5.038.