Skip to content

Conversation

@jackkoenig
Copy link
Contributor

It turns out there was a really easy solution: https://youtrack.jetbrains.com/issue/SCL-24377/Incorrect-No-implicits-found-for-code-using-Chisel-v7.0.0#focus=Comments-27-12709369.0-0

Fixes #4929

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

This works around an issue in IntelliJ around using the macro to materialize SourceInfo.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This works around an issue in IntelliJ around using the macro to
materialize SourceInfo.
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Sep 27, 2025
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@jackkoenig jackkoenig enabled auto-merge (squash) September 27, 2025 02:06
@jackkoenig jackkoenig changed the title Rename SourceInfo$Intf to SourceInfoIntf Rename private[chisel3] SourceInfo$Intf to SourceInfoIntf Sep 27, 2025
@jackkoenig jackkoenig disabled auto-merge September 27, 2025 02:06
@jackkoenig jackkoenig enabled auto-merge (squash) September 27, 2025 02:07
@jackkoenig jackkoenig merged commit 5cb6aa7 into main Sep 27, 2025
16 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/fix-intellij branch September 27, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Fixes a bug, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IntelliJ Errors with Chisel 7.0.0-RC1 Despite Successful Compilation

3 participants