Add option to suppress emission of source locators #5053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdobbie-sifive
approved these changes
Oct 14, 2025
seldridge
approved these changes
Oct 14, 2025
Member
seldridge
left a comment
seldridge
left a comment
There was a problem hiding this comment.
LGTM. Some nits. Take them or leave them.
Comment on lines
60
to
66
| if (!suppressSourceInfo) { | ||
| info match { | ||
| case _: NoSourceInfo => () | ||
| case sl: SourceLine => | ||
| b ++= " @["; b ++= fir.FileInfo.fromUnescaped(sl.serialize).escaped; b ++= "]" | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Nit: consider early return to avoid indentation.
Comment on lines
419
to
426
| val argsWithFlag: Array[String] = argsWithoutFlag ++ Array("--no-source-info") | ||
|
|
||
| // First, generate CHIRRTL without the flag to verify source info is present | ||
| (new ChiselStage) | ||
| .execute( | ||
| argsWithoutFlag, | ||
| Seq(ChiselGeneratorAnnotation(() => new ChiselStageSpec.Foo)) | ||
| ) |
Member
There was a problem hiding this comment.
This would be cleaner using the non-execute formulation and not writing to disk:
ChiselStage.emitCHIRRTL(new ChiselStageSpec.Foo).fileCheck()("CHECK: @[")Similarly, the second test is then just:
ChiselStage.emitCHIRRTL(new ChiselStageSpec.Foo, Array("--no-source-info")).fileCheck()("CHECK-NOT: @[")
Comment on lines
+51
to
+55
| override def mimaBinaryIssueFilters = super.mimaBinaryIssueFilters() ++ Seq( | ||
| // chisel3.internal.firrtl.ir is package private | ||
| ProblemFilter.exclude[DirectMissingMethodProblem]("chisel3.internal.firrtl.ir*"), | ||
| ProblemFilter.exclude[MissingTypesProblem]("chisel3.internal.firrtl.ir*") | ||
| ) |
Member
There was a problem hiding this comment.
Great! I was running into this elsewhere...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Users can now pass
--no-source-infoto suppress emission of source locators in emitted.fir.Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.